update_limits.py #7

  • //
  • guest/
  • perforce_software/
  • sdp/
  • dev/
  • Server/
  • Unix/
  • p4/
  • common/
  • bin/
  • update_limits.py
  • View
  • Commits
  • Open Download .zip Download (3 KB)
#!/usr/bin/env python3
#==============================================================================
# Copyright and license info is available in the LICENSE file included with
# the Server Deployment Package (SDP), and also available online:
# https://swarm.workshop.perforce.com/projects/perforce-software-sdp/view/main/LICENSE
#------------------------------------------------------------------------------

"""
This script makes sure that all Perforce users are in the limits group, so
that limits, specifically Max* settings in the group spec, can easily be
made to apply to all users. If used, this script owns and manages the
membership of the group named 'limits'.

This script's job is only to ensure that users are in the group.  It is expected
that the Perforce Admin will apply appropriate values to the Max* settings of
the group spec for the limits group.  Settings such values causes limits to be
applied.  Until limits are applied, membership in the limits group has no impact.

See 'p4 help group' for more information, and also see:

* https://portal.perforce.com/s/article/2521 
* https://portal.perforce.com/s/article/2529

BE CAREFUL:  Setting the values requires judgement and experience. If Max* values
are set too low, users will be unduly impacted, and will see errors indicating
that they have exceeded limits such as MaxScanRows or MaxOpenFiles. Appropriate
values depend on various factors such as server hardware resources and Helix
Core date size; there are not "one size fits all" values.

For users that should not have limits applied, create a group no_limits, and add
users (perhaps certain trusted automation users) to that group.  Set the Max*
values for that group to the special value 'unlimited'.

"""

import sys, os, string, re

instance=sys.argv[1]

os.system("/p4/common/bin/p4login %s" % instance)
os.system("/p4/common/bin/p4master_run %s /p4/%s/bin/p4_%s group -o limits > %s_limits.txt" % (instance, instance, instance, instance))
os.system("/p4/common/bin/p4master_run %s /p4/%s/bin/p4_%s -ztag -F %%User%% users > %s_users.txt" % (instance, instance, instance, instance))

users = open("%s_users.txt" % instance, "r")

limits = open("%s_limits.txt" % instance, "r")
output = open("%s_newlimits.txt" % instance, "w")

userlist = []

for user in users.readlines():
        user = user.strip()
        if user != "":
                userlist.append(user)

users.close()

for line in limits.readlines():
        if line != "\n":
                output.write(line)

limits.close()

for user in userlist:
        output.write("\t%s\n" % user)

output.close()

os.system("/p4/common/bin/p4master_run %s /p4/%s/bin/p4_%s group -i < %s_newlimits.txt > /dev/null" % (instance, instance, instance, instance))

os.remove("%s_users.txt" % instance)
os.remove("%s_limits.txt" % instance)
os.remove("%s_newlimits.txt" % instance)


# Change User Description Committed
#7 30507 C. Thomas Tyler Fixed typo in doc.
#6 29926 C. Thomas Tyler Fixed bug where script will hang if 'iconv' hangs, which can happen if
certain Unicode characters exists that may appear in a user's FullName
field.

The fix was to remove the 'iconv' utility entirely, thus eliminating the
risk of a hang.  The 'p4 users' command was instead optimized to use
'p4 -ztag -F %User% users' to get just the needed list of users, so that
the FullName fieled is not displayed to begin with (and thus no need for
Unicode tranlsation).

Also changed shebang line to reference python3 rather than python.

Also improved docs.

#review-29927 robert_cowham
#5 29562 lee_marzke Fix update_limits.py to not crash when unicode characters encountered in user names or emails.
#4 19768 UnstoppableDrew @tom_tyler @russell_jackson
Bug fix for running p4master_run as root, and some comment header cleanup. Job 000543

p4master_run: Preserve original arguments list and use this when exec'ing as $OSUSER.

backup_functions.sh: Add text about sourcing p4_vars yourself instead of using p4master_run.

update_limites.py: Run p4login directly without p4master_run since p4login calls p4_vars now.

everything else: Remove comment block about needing to run with p4master_run. Reword comment
  about SDP_INSTANCE since it is not always an integer value.
#3 16029 C. Thomas Tyler Routine merge to dev from main using:
p4 merge -b perforce_software-sdp-dev
#2 12169 Russell C. Jackson (Rusty) Updated copyright date to 2015

 Updated shell scripts to require an instance parameter to eliminate the need
 for calling p4master_run.    Python and Perl still need it since you have to set the
environment for them to run in.

 Incorporated comments from reviewers. Left the . instead of source as that seems
more common in the field and has the same functionality.
#1 10638 C. Thomas Tyler Populate perforce_software-sdp-dev.
//guest/perforce_software/sdp/main/Server/Unix/p4/common/bin/update_limits.py
#1 10148 C. Thomas Tyler Promoted the Perforce Server Deployment Package to The Workshop.