#!/bin/bash #============================================================================== # Copyright and license info is available in the LICENSE file included with # the Server Deployment Package (SDP), and also available online: # https://swarm.workshop.perforce.com/projects/perforce-software-sdp/view/main/LICENSE #------------------------------------------------------------------------------ #============================================================================== # Declarations and Environment if [[ ${BASH_VERSINFO[0]} -lt 4 ]]; then echo -e "\\n\\nERROR: $0 requires bash version 4.x+; current bash version is $BASH_VERSION." exit 1 fi declare StatusMessage="OK: All scanned depots verified OK." declare ThisScript=${0##*} declare ThisUser= declare Version=5.11.0 declare CmdLine="$0 $*" declare -i VerifyOnlyRecentChanges=0 declare -i VerifyFailed= declare -i NoOp=0 declare -i Debug=0 declare -i ShowLog=0 declare -i ExitCode=0 declare -i WaitBetweenVerifies=0 declare -i MaxActivePullQueueSize=0 declare -i MaxTotalPullQueueSize=0 declare -i VerifyCommandCount=0 declare -i VerifyArchived=0 declare -i VerifyChunks=0 declare -i VerifyShelved=1 declare -i VerifySpecDepot=1 declare -i VerifySubmitted=1 declare -i VerifyUnload=1 declare -i GzipOldLog=1 declare -i ScheduleTransfers=1 declare -i ShelvedCLCount=0 declare -i ShelvedCLErrorCount=0 declare -i DepotCount=0 declare -i OverrideCacheSafety=0 declare -a DepotList # VerifyErrors is an associative array of errors indexed as follows: # archive # shelved # spec # submitted # unload # Values are the number of errors (BAD or MISSING) for each type of depot. declare -A VerifyErrors declare SDPInstance= declare SDPEnv="/p4/common/bin/p4_vars" declare DepotListFile= declare RevRange= declare RecentChangesToVerify=200 declare VerifyCmd= declare ChangesCmd= declare ShelvedChangesToVerify= declare ShelvedCL= declare VerifyOnlyOption= declare VerifyOptions= declare ChunkFile= declare ChunkPath= declare ChunkSize= declare ChunkScript="/p4/common/bin/depot_verify_chunks.py" declare Log=Unset declare SummaryLog= declare H1="==============================================================================" declare H2="------------------------------------------------------------------------------" declare TmpFile= declare TmpLog= declare LbrReplication= declare -i NotifyOnlyOnFailure=0 # Preserve orignal behavior of always sending a report. #============================================================================== # Local Functions #------------------------------------------------------------------------------ # Function: usage (required function) # # Input: # $1 - style, either -h (for short form) or -man (for man-page like format). # The default is -h. # # $2 - error message (optional). Specify this if usage() is called due to # user error, in which case the given message displayed first, followed by the # standard usage message (short or long depending on $1). If displaying an # error, usually $1 should be -h so that the longer usage message doesn't # obscure the error message. # # Sample Usage: # usage # usage -man # usage -h "Incorrect command line usage." # # This last example generates a usage error message followed by the short # '-h' usage summary. #------------------------------------------------------------------------------ function usage { declare style=${1:--h} declare errorMessage=${2:-Unset} if [[ $errorMessage != Unset ]]; then echo -e "\\n\\nUsage Error:\\n\\n$errorMessage\\n\\n" >&2 fi echo "USAGE for $ThisScript v$Version: p4verify.sh [<instance>] [-N] [-nu] [-nr] [-ns] [-nS] [-a] [-nt] [-nz] [-o BAD|MISSING] [-chunks <ChunkSize>] [-w <Wait>] [-q <MaxActivePullQueueSize>] [-Q MaxTotalPullQueueSize] [-recent] [-dlf <depot_list_file>] [-Ocache] [-n] [-L <log>] [-v] [-d] [-D] or p4verify.sh -h|-man " if [[ $style == -man ]]; then echo -e "DESCRIPTION: This script performs a 'p4 verify' of all submitted and shelved versioned files in depots of all types except 'remote' and 'archive' type depots. If run on a replica, it schedules archive failures for transfer to the replica. OPTIONS: <instance> Specify the SDP instance. If not specified, the SDP_INSTANCE environment variable is used instead. If the instance is not defined by a parameter and SDP_INSTANCE is not defined, p4verify.sh exists immediately with an error message. -N Specify '-N' (Notify Only On Failure) to disable the default behavior which will always send a notification which includes a report of the p4 verify status. Specifying '-N' which change the behavior to only send a notification if there is an error during the p4 verify execution. Notification methods are email, AWS SNS, and PagerDuty. Details on configuration can be found in the SDP documentation. Providing the environment variable NOTIFY_ONLY_ON_FAILURE=1 is equivalent to the '-N' command line argument. -nu Specify '-nu' (No Unload) to skip verification of the singleton depot of type 'unload' (if created). The 'unload' depot is verified by default. -nr Specify '-nr' (No Regular) to skip verification of regular submitted archive files. The '-nr' option is not compatible with '-recent'. Regular submitted archive files are verified by default. -ns Specify '-ns' (No Spec Depot) to skip verification of singleton depot of type 'spec' (if created). The 'spec' depot is verified by default. -nS Specify '-nS' (No Shelves) to skip verification of shelved archive files, i.e. to skip the 'p4 verify -qS'. -a Specify '-a' (Archive Depots) to do verification of depots of type 'archive'. Depots of type 'archive' are not verified by default, as archive depots are often physically removed from the server's storage subsystem for long-term cold storage. -nt Specify the '-nt' option to avoid passing the '-t' flag to 'p4 verify' on a replica. By default, p4verify.sh detects if it is running on a replica, and if so automatically applies the '-t' flag to 'p4 verify'. That causes the replica to attempt to self-heal, as files that fail verification are scheduled for transfer from the P4TARGET server. This default behavior results in 'Transfer scheduled' messages in the log, and MISSING/BAD files are listed as 'info:' rather than 'error:'. There is no clear indication of whether or which of the scheduled transfers complete successfully, and so there may be a mix of transient/correctable and \"real\"/persistent transfer errors for files that are also BAD/MISSING on the master server. Specify '-nt' to ensure the log contains a list of files that currently fail a 'p4 verify' without attempting to transfer them from the master. -nz Specify '-nt' to skip the gzip of the old log file. By default, if a log with the default name or the name specified with '-L' exists at the start of processing, the old log is rotated and gzipped. With this option the old log is not zipped when rotated. -o BAD|MISSING Specify '-o MISSING' to check only whether expected archive files exist or not, skipping the checksum calculation of existing files. This results in dramatically faster, if less comprehensive, verification. This is particularly well suited when verification is being used to schedule archive file transfers of missing files on replicas. This translates into passing the '--only MISSING' option to 'p4 verify'. Specify '-o BAD' to check only for BAD revisions. This translates into passing the '--only BAD' option to 'p4 verify'. This option requires p4d to be 2021.1 or newer. For older p4d versions, this option is silently ignored. -chunks <ChunkSize> Specify the maximum amount of content by size to verify at once. If this is specified, the depot_verify_chunks.py script is used to break up depots into chunks of a given size, e.g. 100M or 4G. The <ChunkSize> parameter must be a size value valid to pass to the depot_verify_chunks.py script with the '-m' option. That is, specifying '-chunks 200M' translates to calling depot_chunks_verify.sh with '-m 200M' This requires the perforce-p4python3 module to be installed and the python3 in the PATH must be the correct one that uses the P4 module. The -recent and -chunks options are mutually exclusive. Using '-chunks' is likely to result in a significantlly slower overall verify operation, though chuking can make it less impactful when it runs. Using the '-chunks' option may be necessary on very large data sets, e.g. if there insufficient resources to process the largest depots. -w <Wait> Specify the '-w' option, where <Wait> is a positive integer indicating the number of seconds to sleep between individual calls to 'p4 verify' commands. For example, specifying '-w 300' results in a delay of 5 minutes between verify commands. This can be used with '-chunks' to inject a delay between chunked depot paths. Otherwise, the delay is injected between each depot processed. This can significantly lengthen the overall duration of 'p4verify.sh' operation, but can also spread out the resource consumption load on a server machine. If shelves are procossed (regardless of whether '-chunks' is used), the delay is injected between each individual shelved changelist, as shelved changes are verified one changelist at a time. For data sets with a large number of shelves, it may be be wise to process shelves separately from submitted files if '-w' is used, a delay value to apply between depots may be different from that applied to individual changelists. See the '-q' option for a description of how '-q' and '-w' can be used together. -q <MaxActivePullQueueSize> Specify the '-q' option, where <MaxActivePullQueueSize> is a positive integer indicating the maximum number of active pulls allowed before a 'p4 verify' command will be executed to transfer archives. The absolute maximum number of possible active pulls is affected by the number of 'startup.N' threads configured to pull archives files, and whether those threads indicate batching. The threads that pull archive files are those that configured to use the 'pull' command the '-u' option. Typically, a small number of pull threads are configured, between 2 and 10 or perhaps 20. If '-q 1' is specified, new 'p4 verify' commands will only be run when the active pull queue is quiet. Specifying a too-high value, e.g. '-q 50' if only 3 'pull -u' archive pull threads are configured, will be ineffective, as the active pull threads will never exceed 3 (let alone 50). The current active pull queue on a replica is reported by: p4 -ztag -F %replicaTransfersActive% pull -ls This option can be useful if using this p4verify.sh script to pull many or even all archives on a new replica server machine from its target server. The injected delays can give the server time to transfer archives scheduled in one call to 'p4 verify' before calling it again with the goal of avoidng overloading the pull queue. If '-w' and '-q' options are both used, the delay specified by '-w' is ignored unless the active pull queue size is greater than or equal to the specified maximum active pull queue size. The '-w' then essentially determines how frequently the 'p4 pull -ls' is run to check the active pull queue size. A reasonable set of values might be '-q 1 -w 10'. The '-q' option in mutually exclusive with '-nt'. The '-q' option in mutually exclusive with '-Q'. -Q <MaxTotalPullQueueSize> Specify the '-Q' option, where <MaxTotalPullQueueSize> is a positive integer indicating the maximum number of total pulls allowed before a 'p4 verify' command will be executed to transfer archives. In certain scenarios, the pull queue can become quite massive. For example, if a fresh standby replica is seeded from a checkpoint but has no archive files, and then a 'p4verify.sh' is run, the verify will schedule all files to be transferred, perhaps millions. If the pull queue gets too large, it can impact metadata replication. Setting this value may help mitigate issues related to scheduling too many archives pulls at once, by delaying scheduling new archive pulls until enough previously scheduled pulls are completed. This option can be useful in such scenarios, if this p4verify.sh script is used to pull many or even all archives on a new replica server machine from its target server. The injected delays can give the server time to transfer archives scheduled in one call to 'p4 verify' before calling it again with the goal of avoidng overloading the pull queue. If individual depots contain large numbers of files, such that a verify on a single depot will schedule too many files to be transferred at once, it may be necessary to combine this option with the '-chunks' option to avoid overloading the transfer queue. **WARNING**: If there are files that cannot be tranferred from the replica's target server, the value of '-Q' must be set to higher than that number, or an infinite loop may occur. For example, if there are 500 permanent \"legacy\" verify errors on the commit server from 10 years ago that have long since been abandoned, those files can never be transferred to any replica. Running p4verify.sh on the replica will cause those files to be scheduled, but as they cannot be pulled, they will land in the total pull queue. In this scenario, the value set with '-Q' must be greater than 500, or an infinite loop is possible. Specify '-Q 0' to disable checking the total pull queue. The current total pull queue on a replica is reported by: p4 -ztag -F %replicaTransfersTotal% pull -ls This option can be useful if using this p4verify.sh script to pull many or even all archives on a new replica server machine from its target server. The injected delays can give the server time to transfer archives scheduled in one call to 'p4 verify' before calling it again with the goal of avoidng overloading the pull queue. If '-w' and '-Q' options are both used, the delay specified by '-w' is ignored unless the total pull queue size is greater than or equal to the specified maximum total pull queue size. The '-w' then essentially determines how frequently the 'p4 pull -ls' is run to check the total pull queue size. A reasonable set of values might be '-q 50000 -w 10'. The '-Q' option in mutually exclusive with '-nt'. The '-Q' option in mutually exclusive with '-q'. -recent Specify that only recent changelists should be verified. The \$SDP_RECENT_CHANGES_TO_VERIFY variable defines how many changelists are considered recent; the default is $RecentChangesToVerify. If the default is not appropriate for your site, add \"export SDP_RECENT_CHANGES_TO_VERIFY\" to /p4/common/config/p4_N.vars to change the default for an instance, or to /p4/common/bin/p4_vars to change it globally. If \$SDP_RECENT_CHANGES_TO_VERIFY is unset, the default is $RecentChangesToVerify. When -recent is used, neither shelves nor files in the unload depot are verified. -dlf <depot_list_file> Specify a file containing a list of depots to process in the desired order. By default, all depots reported by 'p4 depots', which effectively results in depots processed in alphabetical order. This can be useful in time-sensitive situations where the order of processing can be prioritized, and/or to prevent processing certain depots. The format fo the depot list file is straighforward, one line per depot, without the '//' nor trailling /..., so a list might look like this sample: ProjA ProjB spec .swarm unload archive ProjC Blank lines and lines starting with a '#' are treated as comments and ignored. WARNING: This is not intended to be the primary method of verification, because it would be easy to forget to add new depots to the list file. If the depot list file is not readable, processing aborts. -Ocache Specify '-Ocache' to attempt a verification on a replica configured with a 'lbr.replication' replication configuration setting value of 'cache'. By default, if the 'lbr.replication' configurable is set to 'cache', this script aborts, as replication of such a depot will schedule transfers that are likely unintended. This is a safety feature. The 'cache' mode is generally used on replicas or edge servers with limited disk space. Because running a verify will cause transfers of any missing files, this could result in filling up the disk. Use of '-Ocache' is strongly discouraged unless combined with other options to ensure that only targeted paths are scheduled for transfer. -v Verbose. Show output of verify attempts, which is suppressed by default. Setting SDP_SHOW_LOG=1 in the shell environment has the same effect as -v. The default behavior of this script is to generate no terminal output, but instead to write output into a log file -- see LOGGING below. If '-v' is specified, the generated log is sent to stdout at the end of processing. This flag is not recommended for routine cron operation or for large data sets. The -chunks and -recent options are mutually exclusive. -L <log> Specify the log file to use. The default is /p4/N/logs/p4verify.log Log rotation and old log cleanup logic does not apply to log files specified with -L. Thus, using -L is not recommended for routine scheduled operation, e.g. via crontab. DEBUGGING OPTIONS: -n No-Operation (NO_OP) mode, for debugging. Display certain commands that would be executed without executing them. When '-n' is used, commands that might take a long time to run or affect data are only displayed. Even in '-n' mode, some information-gathering commands such as listing shelved CLs are executed, which may cause the script to take a bit of time to run on a large data set even in dry run mode. -d Specify that debug messages should be displayed. -D Use bash 'set -x' extreme debugging verbosity, and imply '-d'. -L off The special value '-L off' disables logging. This can only be used with '-n' for debugging. HELP OPTIONS: -h Display short help message -man Display man-style help message EXAMPLES: Example 1: Full Verify This script is typically called via cron with only the instance parameter as an argument, e.g.: p4verify.sh 1 Example 2: Fast Verify A \"fast\" verify is one in which only the check for MISSING archives is done, while the resource-intensive checksum calculation of potentially BAD existing archives is skipped. This is especially useful when used on a replica. p4verify.sh 1 -o MISSING Example 3: Fast and Recent Verify The '-o MISSING' and '-recent' flags can be combined for a very fast check. This check might be incorporated into a failover procedure. p4verify.sh 1 -o MISSING -recent Example 4: Submitted Files Only This will verify only use submitted files, ignoring shelves and the spec and unload depots, putting the results in a specified log: p4verify.sh 1 -ns -nS -nu -L -L /p4/1/logs/p4verify.submitted.log Example 5: Shelved Files Only This will verify only use submitted files, ignoring shelves and the spec and unload depots, putting them in a specified log: p4verify.sh 1 -nr -ns -nu -L /p4/1/logs/p4verify.shelved.log Example 6: A Dry Run The '-n' option can be used for a dry run. Output may also be displayed to the screen ('-v') for a dry run and the log file optionally discarded: p4verify.sh 1 -n -nS -L off -v Example 7: Archive File Load for New Replica The p4verify.sh script can be used to schedule transfers of a large number of files from a replica. When doing so, however, overloading the new replicas pull queue with too many files may impact metadata replication. This can be addressed by combining a variety of options, such as '-chunks' and '-Q'. For example: p4verify.sh 1 -chunks 200M -Q 10000 -w 20 -o MISSING NOHUP USAGE: Because archive verification is typically a long running task, it is advisable to use 'nohup' to call each command, and combine that by running the command as a background process. Alternately, use 'screen' or similar. Any of the examples above can be used with 'nohup', without output redirected to /dev/null (i.e. to \"the void\", as this script handles logging and output redirection). To use 'nohup', start the command line with 'nohup', and then after the command, add this text exactly: < /dev/null > /dev/null 2>&1 & As a example, Example 2 above, called with nohup, would look like: nohup /p4/common/bin/p4verify.sh 1 -o MISSING < /dev/null > /dev/null 2>&1 & With the ampersand '&' at the end, the command will appear to return immediately as the process continues to run in the background. Then optionally monitor the log: tail -f /p4/1/logs/p4verify.log LOGGING: This script generates no output by default. All (stdout and stderr) is logged to /p4/N/logs/p4verify.log. The exception is usage errors, which result an error being sent to stderr followed usage info on stdout, followed by an immediate exit. NOTIFICATIONS: In addition to logging, a short summary of the verify is sent as a notification. The summary is reliably short even if the output of the verifications done by this script results in a large log file. There are two notification schemes with this script: * Email notification is always attempted. * AWS SNS notification is attempted if the SNS_ALERT_TOPIC_ARN custom setting is defined. This is typically set in: /p4/common/site/config/p4_N.vars.local EXIT CODES: An exit code of 0 indicates no errors were encountered attempting to perform verifications, AND that all verifications attempted reported no problems. A exit status of 1 indicates that verifications could not be attempted for some reason. A exit status of 2 indicates that verifications were successfully performed, but that problems such as BAD or MISSING files were detected, or else system limits prevented verification. " fi exit 1 } #------------------------------------------------------------------------------ # Function: terminate function terminate { # Disable signal trapping. trap - EXIT SIGINT SIGTERM [[ "$Log" == "off" ]] || msg "Log is: $Log\\n${H1}" # Be tidy. [[ -n "$TmpFile" && -e "$TmpFile" ]] && rm -f "$TmpFile" # With the trap removed, exit. exit "$ExitCode" } function msg () { echo -e "$*"; } function dbg () { [[ "$Debug" -eq 0 ]] || msg "DEBUG: $*"; } function errmsg () { msg "\\nError: ${1:-Unknown Error}\\n"; ErrorCount+=1; } function bail () { errmsg "${1:-Unknown Error}"; exit; } #------------------------------------------------------------------------------ # Function: get_verify_rev_range ($depot, $recentChanges) #------------------------------------------------------------------------------ function get_verify_rev_range () { declare depot=${1:-} declare recentChangesToVerify=${2:-} declare nowChange= [[ -z "$depot" || -z "$recentChangesToVerify" ]] && return 0 nowChange=$("$P4BIN" -ztag -F %change% changes -m 1 "//$depot/...") thenChange=$("$P4BIN" -ztag -F %change% changes -m "$recentChangesToVerify" "//$depot/..." | tail -1) [[ -z "$nowChange" ]] && return 1 [[ -z "$thenChange" ]] && return 1 echo "@$thenChange,@$nowChange" return 0 } #------------------------------------------------------------------------------ # Function: delay_between_verifies ($WaitBetweenVerifies, $MaxActivePullQueueSize, $MaxTotalPullQueueSize) # # References global(s): $VerifyCommandCount #------------------------------------------------------------------------------ function delay_between_verifies () { local -i waitBetweenVerifies=${1:-0} local -i maxActivePullQueueSize=${2:-0} local -i maxTotalPullQueueSize=${3:-0} local -i activePullQueueSize=0 local -i totalPullQueueSize=0 local -i pullQueueCheckDelay=10 # Short-circuit: Return if no verifies have yet been processed. [[ "$VerifyCommandCount" -eq 0 ]] && return # Short-circuit: Return if no delay-inducing options are set: '-q', '-Q', or '-w'. [[ "$maxActivePullQueueSize" -eq 0 && "$maxTotalPullQueueSize" -eq 0 && "$waitBetweenVerifies" -eq 0 ]] && return # If only the '-w <Wait>' was specified, just wait. if [[ "$maxActivePullQueueSize" -eq 0 && "$maxTotalPullQueueSize" -eq 0 ]]; then dbg "Sleeping $waitBetweenVerifies seconds." sleep "$waitBetweenVerifies" # If only the '-q <MaxActivePullQueueSize>' was specified, wait until the # max active pulls is below the specified limit. If both '-q' and '-w' are # specified, apply the delay of '-w' iff the pull queue is low enough per # '-q'. elif [[ "$maxActivePullQueueSize" -ne 0 ]]; then [[ "$waitBetweenVerifies" -ne 0 ]] && pullQueueCheckDelay=$waitBetweenVerifies activePullQueueSize=$($P4 -ztag -F %replicaTransfersActive% pull -ls 2>/dev/null) dbg "delay_between_verifies(): Active Pull Queue Size: $activePullQueueSize" if [[ -n "$activePullQueueSize" ]]; then while [[ "$activePullQueueSize" -gt "$maxActivePullQueueSize" ]]; do dbg "Sleeping $pullQueueCheckDelay seconds because active pull queue of $activePullQueueSize is greater than max $maxActivePullQueueSize." sleep "$pullQueueCheckDelay" activePullQueueSize=$($P4 -ztag -F %replicaTransfersActive% pull -ls 2>/dev/null) dbg "delay_between_verifies(): Active Pull Queue Size: $activePullQueueSize" if [[ -z "$activePullQueueSize" ]]; then errmsg "delay_between_verifies(): Could not determine active pull queue size in delay loop." break fi done dbg "Delay due to -q completed." else # We could not determine the active pull queue size. # Display an error and move on. errmsg "delay_between_verifies(): Could not determine initial active pull queue size." fi else [[ "$waitBetweenVerifies" -ne 0 ]] && pullQueueCheckDelay=$waitBetweenVerifies totalPullQueueSize=$($P4 -ztag -F %replicaTransfersTotal% pull -ls 2>/dev/null) dbg "delay_between_verifies(): Total Pull Queue Size: $totalPullQueueSize" if [[ -n "$totalPullQueueSize" ]]; then while [[ "$totalPullQueueSize" -gt "$maxTotalPullQueueSize" ]]; do dbg "Sleeping $pullQueueCheckDelay seconds because total pull queue of $totalPullQueueSize is greater than max $maxTotalPullQueueSize." sleep "$pullQueueCheckDelay" totalPullQueueSize=$($P4 -ztag -F %replicaTransfersTotal% pull -ls 2>/dev/null) dbg "delay_between_verifies(): Active Pull Queue Size: $totalPullQueueSize" if [[ -z "$totalPullQueueSize" ]]; then errmsg "delay_between_verifies(): Could not determine total pull queue size in delay loop." break fi done dbg "Delay due to -Q completed." else # We could not determine the total pull queue size. # Display an error and move on. errmsg "delay_between_verifies(): Could not determine initial total pull queue size." fi fi } #------------------------------------------------------------------------------ # Function: call_p4verify($verifyErrorType, $verifyCommand) # # This calls the 'p4 verify' command with the command given, and increments # count of errors indexted by verify, updating the VerifiyErrors array # displayed in the summary. # # VerifyErrors is an associative array of errors indexed as follows: # archive # shelved # spec # submitted # unload # # Values are the number of errors (including BAD/MISSING/other) for each type. # function call_p4verify () { local -i status local verifyErrorType="${1:-}" local verifyCommand="${2:-}" local tmpf= local oldErrors= local newErrors= local totalErrors= [[ -n "$verifyErrorType" || -n "$verifyCommand" ]] || return msg "${H2}\\nRunning: $verifyCommand" tmpf="${P4TMP}/t_verify.$$.$RANDOM" if [[ "$NoOp" -eq 0 ]]; then eval "$verifyCommand" > "$tmpf" 2>&1 status=$? # Suppress 'no such file' errors from older p4d versions to avoid # confusion, as these are not actual errors. In newer p4d versions, # this is a mere warning, which we don't suppress. grep -Ev "^error: //.*/... - no such file(s)." "$tmpf" # See if there are any new errors: newErrors=$(grep -Ec '(BAD!|MISSING!|p4 help max)' "$tmpf") if [[ "$newErrors" =~ [0-9]+ ]]; then if [[ "$newErrors" != "0" ]]; then oldErrors=${VerifyErrors[$verifyErrorType]:-0} totalErrors=$((oldErrors+newErrors)) VerifyErrors[$verifyErrorType]="$totalErrors" fi else errmsg "Unable to count verify errors in [$tmpf]." fi rm -f "$tmpf" else msg "NO_OP: Would run: $verifyCommand" status=0 fi VerifyCommandCount+=1 return "$status" } #============================================================================== # Command Line Processing declare -i shiftArgs=0 set +u while [[ $# -gt 0 ]]; do case "$1" in (-h) usage -h;; (-man) usage -man;; (-N) NotifyOnlyOnFailure=1;; (-ns) VerifySpecDepot=0;; (-nS) VerifyShelved=0;; (-nr) VerifySubmitted=0;; (-nu) VerifyUnload=0;; (-a) VerifyArchived=1;; (-w) shiftArgs=1 if [[ "$2" =~ ^[1-9]+[0-9]*$ ]]; then WaitBetweenVerifies=$2 else usage -h "Invalid parameter '-w $2'; the value with '-w' must be a positive integer." fi ;; (-q) shiftArgs=1 if [[ "$2" =~ ^[1-9]+[0-9]*$ ]]; then MaxActivePullQueueSize=$2 else usage -h "Invalid parameter '-q $2'; the value with '-q' must be a positive integer." fi ;; (-Q) shiftArgs=1 if [[ "$2" =~ ^[1-9]+[0-9]*$ ]]; then MaxTotalPullQueueSize=$2 else usage -h "Invalid parameter '-Q $2'; the value with '-Q' must be a positive integer." fi ;; (-nt) ScheduleTransfers=0;; (-nz) GzipOldLog=0;; (-o) VerifyOnlyOption="--only ${2^^}"; shiftArgs=1;; (-chunks) VerifyChunks=1; ChunkSize="$2"; shiftArgs=1;; (-recent) VerifyOnlyRecentChanges=1;; (-dlf) DepotListFile="${2:-}"; shiftArgs=1;; (-Ocache) OverrideCacheSafety=1;; (-n) NoOp=1;; (-v) ShowLog=1;; (-L) Log="$2"; shiftArgs=1;; (-d) Debug=1;; (-D) Debug=1; set -x;; # Debug; use bash 'set -x' extreme debugging mode. (-*) usage -h "Unknown command line option ($1).";; (*) if [[ -z "$SDPInstance" ]]; then SDPInstance="$1" else usage -h "Unknown extra parameter [$1]." fi ;; esac # Shift (modify $#) the appropriate number of times. shift; while [[ $shiftArgs -gt 0 ]]; do [[ $# -eq 0 ]] && usage -h "Incorrect number of arguments." shiftArgs=$shiftArgs-1 shift done done set -u #============================================================================== # Command Line Verification [[ -z "$SDPInstance" ]] && SDPInstance="${SDP_INSTANCE:-UnsetSDPInstance}" [[ "$SDPInstance" == "UnsetSDPInstance" ]] && \ usage -h "The \\$SDP_INSTANCE setting is not defined. It must be defined by doing:\\n\\n\\tsource /p4/common/bin/p4_vars <instance>\\n\\nor by passing in the instance name as a parameter to this script.\\n" # Load SDP Environment. In case this generates output on stdout, suppress it to # avoid triggering crontab emails, but do not suppress stderr (output related # to errors). # shellcheck disable=SC1090 source "$SDPEnv" "$SDPInstance" > /dev/null ||\ bail "Failed to load SDP environment with:\\n\\tsource $SDPEnv $SDPInstance" # shellcheck disable=SC1091 source /p4/common/bin/backup_functions.sh ||\ bail "Failed to load backup_functions.sh with:\\n\\tsource /p4/common/bin/backup_functions.sh" [[ "$VerifySubmitted" -eq 0 && "$VerifyOnlyRecentChanges" -eq 1 ]] && \ usage -h "The '-recent' and '-nr' options are mutually exclusive." if [[ -n "$VerifyOnlyOption" ]]; then # shellcheck disable=SC2072 if [[ "$P4D_VERSION" > "2021.1" ]]; then if [[ ! "$VerifyOnlyOption" =~ ^--only\ (MISSING|BAD)$ ]]; then usage -h "The option specified with '-o' must be BAD or MISSING. Specified value was: $VerifyOnlyOption" fi else VerifyOnlyOption= fi fi [[ "$VerifyOnlyRecentChanges" -eq 1 && "$VerifyChunks" -eq 1 ]] && \ usage -h "The -recent and -chunks options are mutually exclusive." if [[ -n "$ChunkSize" && ! -x "$ChunkScript" ]]; then msg "Warning: -chunks ignored because chunking script is not executable by user $ThisUser: $ChunkScript" VerifyChunks=0 fi [[ -n "$DepotListFile" && ! -r "$DepotListFile" ]] && \ usage -h "The file specified with '-dlf <depot_list-file>' does not exist: $DepotListFile" [[ "$ScheduleTransfers" -eq 0 && "$MaxActivePullQueueSize" -ne 0 ]] && \ usage -h "The file '-nt' and '-q <MaxActivePullQueueSize>' options are mutually exclusive." [[ "$ScheduleTransfers" -eq 0 && "$MaxTotalPullQueueSize" -ne 0 ]] && \ usage -h "The file '-nt' and '-Q <MaxTotalPullQueueSize>' options are mutually exclusive." [[ "$MaxActivePullQueueSize" -ne 0 && "$MaxTotalPullQueueSize" -ne 0 ]] && \ usage -h "The file '-q <MaxActivePullQueueSize>' and '-Q <MaxTotalPullQueueSize>' options are mutually exclusive." [[ "${P4REPLICA}" == "FALSE" && "$MaxActivePullQueueSize" -ne 0 ]] && \ usage -h "The '-q <MaxActivePullQueueSize>' option can only be used on a replica; the ServerID [$SERVERID] does not appear to be a replica." [[ "$Log" == off && "$NoOp" -eq 0 ]] && \ usage -h "The '-L off' option can only be specified with '-n' (NO_OP/Dry Run mode)." #============================================================================== # Main Program trap terminate EXIT SIGINT SIGTERM # '-N' command line argument is available to disable the default notification behavior # check if the other option, environment variable, was used [[ -n "${NOTIFY_ONLY_ON_FAILURE:-}" ]] && \ NotifyOnlyOnFailure="${NOTIFY_ONLY_ON_FAILURE}" # If $SDP_RECENT_CHANGES_TO_VERIFY, use that, else default to the value set for # $RecentChangesToVerify in this script. [[ -n "${SDP_RECENT_CHANGES_TO_VERIFY:-}" ]] && \ RecentChangesToVerify="${SDP_RECENT_CHANGES_TO_VERIFY}" [[ "$Log" == Unset ]] && Log="$LOGS/p4verify.log" if [[ "$Log" != off ]]; then SummaryLog="$(mktemp "${P4TMP}/email_summary.XXXXXXXXX.txt")" if [[ -e "$Log" ]]; then OldLogTimestamp=$(get_old_log_timestamp "$Log") OldLog="$LOGS/p4verify.${OldLogTimestamp}.log" mv -f "$Log" "$OldLog" || bail "Could not do: mv -f \"$Log\" \"$OldLog\"" # Gzip old log. if [[ "$GzipOldLog" -eq 1 && -n "$(command -v gzip)" ]]; then dbg "gzip --best \"$OldLog\"" gzip --best "$OldLog" fi dbg "Rotated old log $Log to $OldLog" fi touch "$Log" || bail "Couldn't touch new log file [$Log]."? # Redirect stdout and stderr to a log file. if [[ "$ShowLog" -eq 1 ]]; then exec > >(tee "$Log") exec 2>&1 else exec >"$Log" exec 2>&1 fi msg "${H1}\\nLog is: $Log\\n" fi ThisUser=$(id -n -u) msg "Started $ThisScript v$Version as $ThisUser@${HOSTNAME%%.*} on $(date +'%a %Y-%m-%d %H:%M:%S %Z') as:\\n$CmdLine" P4="$P4BIN -p $P4PORT -u $P4USER" "$P4CBIN/p4login" msg "If there are errors in this log, contact support-helix-core@perforce.com" VerifyFailed=0 if [[ "$VerifyOnlyRecentChanges" -eq 1 ]]; then msg "Info: Verifying only $RecentChangesToVerify changelists per depot due to -recent.\\n" fi # If we are on a replica or edge server, the lbr.replication value will be defined. # If it is set to 'cache' (or the unsupported alias 'ondemand'), abort unless the # '-Ocache' option was specified. LbrReplication=$($P4 -ztag -F %Value% configure show lbr.replication 2>/dev/null) if [[ -n "$LbrReplication" ]]; then if [[ "$LbrReplication" =~ ^(cache|ondemand)$ ]]; then if [[ "$OverrideCacheSafety" -eq 1 ]]; then msg "The lbr.replication value is '$LbrReplication'. Proceeding due to '-Ocache'." else bail "Aborting because the lbr.replication value is '$LbrReplication'. See description of '-Ocache' opion for more info." fi fi fi RevRange= # Determine the list of depots to process, either from 'p4 depots' or from a # specified depot list file. if [[ -n "$DepotListFile" ]]; then TmpFile=$(mktemp) grep -Ev '^\s*$|^\s*\#' "$DepotListFile" > "$TmpFile" if [[ -s "$TmpFile" ]]; then while read -r d; do DepotList[$DepotCount]="$d" DepotCount+=1 done < "$TmpFile" else bail "No depots to process from the depot list file $DepotListFile (trimmed in $TmpFile)." fi else for d in $($P4 -ztag -F %name% depots); do DepotList[$DepotCount]="$d" DepotCount+=1 done fi msg "Processing ${#DepotList[@]} depots." for d in "${DepotList[@]}"; do depotType=$($P4 -ztag -F %Type% depot -o "$d") delay_between_verifies "$WaitBetweenVerifies" "$MaxActivePullQueueSize" "$MaxTotalPullQueueSize" case "$depotType" in (archive) [[ "$VerifyArchived" -eq 1 ]] || continue # For archive depots, use -A and -q but not -z. if [[ -n "$VerifyOnlyOption" ]]; then VerifyOptions="-q $VerifyOnlyOption -A" else VerifyOptions="-q -A" fi [[ "${P4REPLICA}" == "FALSE" || "${SHAREDDATA}" == "TRUE" || "$ScheduleTransfers" -eq 0 ]] || VerifyOptions+=" -t" msg "=== Started verify of archive depot //$d/... at $(date)." VerifyCmd="$P4 -s verify $VerifyOptions //$d/..." call_p4verify archive "$VerifyCmd" || VerifyFailed=1 ;; (remote) msg "\\nInfo: Skipping verify of remote depot $d.\\n" continue ;; (spec) [[ "$VerifySpecDepot" -eq 1 ]] || continue # For the spec depot, there are no lazy copies, so no need for -z. if [[ -n "$VerifyOnlyOption" ]]; then VerifyOptions="-q $VerifyOnlyOption" else VerifyOptions="-q" fi [[ "${P4REPLICA}" == "FALSE" || "${SHAREDDATA}" == "TRUE" || "$ScheduleTransfers" -eq 0 ]] || VerifyOptions+=" -t" msg "=== Started verify of spec depot //$d/... at $(date)." VerifyCmd="$P4 -s verify $VerifyOptions //$d/..." call_p4verify spec "$VerifyCmd" || VerifyFailed=1 ;; (unload) [[ "$VerifyUnload" -eq 1 ]] || continue # For the unload depot, there are no lazy copies, so no need for -z. if [[ -n "$VerifyOnlyOption" ]]; then VerifyOptions="-q $VerifyOnlyOption -U" else VerifyOptions="-q -U" fi [[ "${P4REPLICA}" == "FALSE" || "${SHAREDDATA}" == "TRUE" || "$ScheduleTransfers" -eq 0 ]] || VerifyOptions+=" -t" msg "=== Started verify of unload depot at $(date)." VerifyCmd="$P4 -s verify $VerifyOptions //$d/..." call_p4verify unload "$VerifyCmd" || VerifyFailed=1 ;; (*) [[ "$depotType" != "local" && "$depotType" != "stream" ]] && \ msg "Warning: Unknown depot type [$depotType]. Attempting normal verify." if [[ "$VerifyOnlyRecentChanges" -eq 1 ]]; then RevRange=$(get_verify_rev_range "$d" "$RecentChangesToVerify") fi ChunkFile="$P4TMP/depot_chunks.$d.txt" rm -f "$ChunkFile" if [[ "$VerifyChunks" -eq 1 ]]; then msg "Running: $ChunkScript -v ERROR -m $ChunkSize //$d/..." if ! "$ChunkScript" -v ERROR -m "$ChunkSize" "//$d/..." > "$ChunkFile"; then msg "Warning: Not chunking //$d/... due to script error." rm -f "$ChunkFile" fi if [[ ! -s "$ChunkFile" ]]; then msg "Warning: Not chunking //$d/... due to zero-size chunk file." rm -f "$ChunkFile" fi else rm -f "$ChunkFile" fi # For stream/local depots, use -z unless --only is used. if [[ -n "$VerifyOnlyOption" ]]; then VerifyOptions="-q $VerifyOnlyOption" else VerifyOptions="-qz" fi [[ "${P4REPLICA}" == "FALSE" || "${SHAREDDATA}" == "TRUE" || "$ScheduleTransfers" -eq 0 ]] || VerifyOptions+=" -t" if [[ "$VerifySubmitted" -eq 1 ]]; then if [[ "$VerifyChunks" -eq 1 && -s "$ChunkFile" ]]; then msg "=== Started verify of submitted files in //$d/... in $ChunkSize chunks at $(date)." while read -r ChunkPath; do VerifyCmd="$P4 -s verify $VerifyOptions \"$ChunkPath\"" call_p4verify submitted "$VerifyCmd" || VerifyFailed=1 done < "$ChunkFile" else msg "=== Started verify of submitted files in //$d/... at $(date)." VerifyCmd="$P4 -s verify $VerifyOptions //$d/...$RevRange" call_p4verify submitted "$VerifyCmd" || VerifyFailed=1 fi fi ;; esac done if [[ "$VerifyShelved" -eq 1 ]]; then msg "=== Started verify of shelved changelists at $(date)." TmpFile=$(mktemp) TmpLog=$(mktemp) ChangesCmd="$P4BIN -ztag -F %change% changes -s shelved" [[ "$VerifyOnlyRecentChanges" -eq 1 ]] && \ ChangesCmd+=" -m $RecentChangesToVerify" ShelvedCLCount=0 ShelvedCLErrorCount=0 # For shelves, don't use -z since we verify change-by-change. if [[ -n "$VerifyOnlyOption" ]]; then VerifyOptions="-q $VerifyOnlyOption -S" else VerifyOptions="-q -S" fi [[ "${P4REPLICA}" == "FALSE" || "${SHAREDDATA}" == "TRUE" || "$ScheduleTransfers" -eq 0 ]] || VerifyOptions+=" -t" if $ChangesCmd > "$TmpFile"; then ShelvedChangesToVerify=$(wc -l "$TmpFile" | cut -d ' ' -f 1) msg "Verifying $ShelvedChangesToVerify shelved changelists." while read -r ShelvedCL; do delay_between_verifies "$WaitBetweenVerifies" "$MaxActivePullQueueSize" "$MaxTotalPullQueueSize" VerifyCommandCount+=1 ShelvedCLCount+=1 VerifyCmd="$P4 -s verify $VerifyOptions @=$ShelvedCL" # Capture temp log for each CL verify command. Display only logs with # error; discard others. if [[ "$NoOp" -eq 0 ]]; then if eval "$VerifyCmd" > "$TmpLog" 2>&1; then rm -f "$TmpLog" else ShelvedCLErrorCount+=1 cat "$TmpLog" rm -f "$TmpLog" fi else # There may be a great many shelves. In NoOp we are silent here # unless '-d' is used. dbg "NO_OP: Would run: $VerifyCmd" fi done < "$TmpFile" else msg "Error: Could not get or write list of shelved changes." VerifyFailed=1 fi if [[ "$ShelvedCLCount" -ne 0 ]]; then if [[ "$ShelvedCLErrorCount" -eq 0 ]]; then msg "\\nAll $ShelvedCLCount shelved changes verified OK." else msg "\\nOf $ShelvedCLCount shelved changes verified, $ShelvedCLErrorCount had errors." VerifyFailed=1 fi else msg "\\nThere were no shelved changelists to verify." fi else msg "Skipping verify of shelved changelists due to '-nS'." fi if [[ "$VerifyFailed" -ne 0 ]]; then StatusMessage="Error: Verify attempt failed. Review the log [$Log]." ExitCode=1 fi if [[ "$ExitCode" -eq 0 ]]; then # Note: Ignore SC2196 due to 'grep -e' and 'egrep' not having consistent # results on all platforms. # shellcheck disable=SC2196 if egrep -m1 '(BAD!|MISSING!|p4 help max)' "$Log" > /dev/null 2>&1; then StatusMessage="Error: Verify errors detected. Review the log [$Log]." ExitCode=2 fi fi msg "Completed verifications at $(date), taking $((SECONDS/3600)) hours $((SECONDS%3600/60)) minutes $((SECONDS%60)) seconds.\\n" if [[ -n "$SummaryLog" ]]; then # Set LOGFILE as an alias for $SummaryLog. LOGFILE is used in the library functions # in backup_functions.sh for notification handling. export LOGFILE="$SummaryLog" echo -e "Summary from $ThisScript v$Version operated as $ThisUser@${HOSTNAME%%.*} Status: $StatusMessage Completed verifications at $(date), taking $((SECONDS/3600)) hours $((SECONDS%3600/60)) minutes $((SECONDS%60)) seconds. Command line was:\\n\\t$CmdLine " > "$SummaryLog" if [[ "$ExitCode" -ne 0 ]]; then echo -e "Summary of Errors by Type:" >> "$SummaryLog" if [[ "$VerifyArchived" -eq 1 ]]; then echo -e " Archive Depot Errors: ${VerifyErrors[archive]:-0}" >> "$SummaryLog" fi if [[ "$VerifySubmitted" -eq 1 ]]; then echo -e " Submitted File Errors: ${VerifyErrors[submitted]:-0}" >> "$SummaryLog" fi if [[ "$VerifySpecDepot" -eq 1 ]]; then echo -e " Spec Depot Errors: ${VerifyErrors[spec]:-0}" >> "$SummaryLog" fi if [[ "$VerifyUnload" -eq 1 ]]; then echo -e " Unload Depot Errors: ${VerifyErrors[unload]:-0}" >> "$SummaryLog" fi # Do some quick math. if [[ "$VerifyArchived" -eq 1 || "$VerifySubmitted" -eq 1 || "$VerifySpecDepot" -eq 1 || "$VerifyUnload" -eq 1 ]]; then declare -i total=0 for errorType in "${!VerifyErrors[@]}"; do total+=${VerifyErrors[$errorType]:-0} done echo -e " Total Non-Shelve Errors: $total (sum of error types listed above)" >> "$SummaryLog" fi if [[ "$VerifyShelved" -eq 1 ]]; then echo -e "\\n Shelved Changes with Errors: $ShelvedCLErrorCount" >> "$SummaryLog" fi fi echo -e "\\nA total of $VerifyCommandCount 'p4 verify' commands were executed." echo -e "\\nDetailed log is:\\n\\t${HOSTNAME%%.*}:$Log " >> "$SummaryLog" msg "${H2}\\nBEGIN Summary Log Contents:" cat "$SummaryLog" msg "END Summary Log Contents\\n${H2}" if [[ "$NotifyOnlyOnFailure" -eq 0 ]]; then mail_log_file "$HOSTNAME $P4SERVER P4Verify Log ($StatusMessage)" else if [[ "$ExitCode" -ne 0 ]]; then die "p4 verify had error: $HOSTNAME $P4SERVER P4Verify Log ($StatusMessage)" else msg "NotifyOnlyOnFailure is set to 1 and the Exitcode is 0. Notifications disabled." fi fi msg "Using email for log summary delivery." mail_log_file "$HOSTNAME $P4SERVER P4Verify Log ($StatusMessage)" fi # See the terminate() function where this script actually exits. exit "$ExitCode"
# | Change | User | Description | Committed | |
---|---|---|---|---|---|
#34 | 30388 | C. Thomas Tyler |
Released SDP 2024.1.30385 (2024/06/11). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#33 | 30297 | C. Thomas Tyler |
Released SDP 2023.2.30295 (2024/05/08). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#32 | 30043 | C. Thomas Tyler |
Released SDP 2023.2.30041 (2023/12/22). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#31 | 29891 | C. Thomas Tyler |
Released SDP 2023.1.29699 (2023/07/11). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#30 | 29701 | C. Thomas Tyler |
Released SDP 2023.1.29699 (2023/07/11). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#29 | 29612 | C. Thomas Tyler |
Released SDP 2023.1.29610 (2023/05/25). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#28 | 29143 | C. Thomas Tyler |
Released SDP 2022.1.29141 (2022/10/29). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#27 | 28989 | C. Thomas Tyler |
Released SDP 2022.1.28987 (2022/08/25). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#26 | 28858 | C. Thomas Tyler |
Released SDP 2022.1.28855 (2022/05/27). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#25 | 28240 | C. Thomas Tyler |
Released SDP 2021.1.28238 (2021/11/12). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#24 | 27761 | C. Thomas Tyler |
Released SDP 2020.1.27759 (2021/05/07). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#23 | 27331 | C. Thomas Tyler |
Released SDP 2020.1.27325 (2021/01/29). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#22 | 25596 | C. Thomas Tyler |
Released SDP 2019.2.25594 (2019/05/02). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#21 | 25483 | C. Thomas Tyler |
Released SDP 2019.1.25480 (2019/04/11). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#20 | 25245 | C. Thomas Tyler |
Released SDP 2019.1.25238 (2019/03/02). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#19 | 24966 | C. Thomas Tyler | Adjusted version. | ||
#18 | 24961 | Karl Wirth |
Fix for SDP-362. Move testing of variable till after the environment has been sourced. |
||
#17 | 22185 | C. Thomas Tyler |
Released SDP 2017.2.22177 (2017/05/17). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#16 | 21244 | C. Thomas Tyler |
Released SDP 2016.2.21239 (2016/12/06). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#15 | 21035 | C. Thomas Tyler |
Released SDP 2016.2.21033 (2016/11/10). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#14 | 20997 | C. Thomas Tyler |
Released SDP 2016.2.20995 (2016/11/07). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#13 | 20974 | C. Thomas Tyler |
Released SDP 2016.2.20972 (2016/11/01). Copy Up using 'p4 copy -r -b perforce_software-sdp-dev'. |
||
#12 | 20353 | C. Thomas Tyler |
Released SDP 2016.1.20348. Copy Up using 'p4 copy -r -b perforce_software-sdp-dev', with selective removal of changes related to work-in-progress changes. |
||
#11 | 19414 | C. Thomas Tyler | Released SDP/MultiArch/2016.1/19410 (2016/05/17). | ||
#10 | 15856 | C. Thomas Tyler |
Replaced the big license comment block with a shortened form referencing the LICENSE file included with the SDP package, and also by the URL for the license file in The Workshop. |
||
#9 | 15777 | C. Thomas Tyler |
No functional changes. Style Policing only on bash scripts only. Normalized indentation and line breaks, removed offending tabs, and general whitespace usage. |
||
#8 | 13908 | C. Thomas Tyler | Pushing SDP 2015.1.13906. | ||
#7 | 12938 | Russell C. Jackson (Rusty) | Adding a missing stderr redirect. | ||
#6 | 12171 | Russell C. Jackson (Rusty) | Merge in changes to remove the need for p4master_run. | ||
#5 | 11757 | Russell C. Jackson (Rusty) | Made the check for the unload depot more specific so it will only pick up an unload depot, and not depots with unload as part of the name or description. | ||
#4 | 11707 | Robert Cowham |
Refactored sending of mail to a common function. Make the setting of "MAILFROM" work for Ubuntu (GNU Mailutils) as well as CentOS |
||
#3 | 11570 | Russell C. Jackson (Rusty) |
Brought in changes from Mark Foundry to add -S $MAILFROM to mail commands. Changed sync_replica.sh and weekly_sync_replica.sh to use $LOGFILE for consistency. Added mail command to both files as well. |
||
#2 | 11524 | Russell C. Jackson (Rusty) | Released updated version of the SDP from Dev. | ||
#1 | 10148 | C. Thomas Tyler | Promoted the Perforce Server Deployment Package to The Workshop. |