package org.jenkinsci.plugins.p4.review; import hudson.model.Action; import hudson.model.ParameterValue; import hudson.model.AbstractProject; import hudson.model.Cause; import hudson.model.CauseAction; import hudson.model.ParameterDefinition; import hudson.model.ParametersAction; import hudson.model.Queue; import hudson.model.StringParameterDefinition; import hudson.model.StringParameterValue; import java.io.IOException; import java.util.ArrayList; import java.util.Enumeration; import java.util.List; import java.util.logging.Logger; import javax.servlet.ServletException; import jenkins.model.Jenkins; import jenkins.util.TimeDuration; import net.sf.json.JSONObject; import org.kohsuke.stapler.StaplerRequest; import org.kohsuke.stapler.StaplerResponse; public class ReviewAction implements Action { private final AbstractProject<?, ?> project; public AbstractProject<?, ?> getProject() { return project; } public ReviewAction(AbstractProject<?, ?> project) { this.project = project; } public String getIconFileName() { return "/plugin/p4/icons/p4.png"; } public String getDisplayName() { return "Build Review"; } public String getUrlName() { return "review"; } /** * Jelly Method * * @return */ public List<StringParameterValue> getAvailableParameters() { List<StringParameterValue> stringParameters = new ArrayList<StringParameterValue>(); for (ParameterDefinition parameterDefinition : getParameterDefinitions()) { StringParameterValue stringParameter = new StringParameterValue( parameterDefinition.getName(), parameterDefinition.getDescription()); stringParameters.add(stringParameter); } return stringParameters; } public void doBuildSubmit(StaplerRequest req, StaplerResponse rsp) throws IOException, ServletException { JSONObject formData = req.getSubmittedForm(); if (!formData.isEmpty()) { doBuild(req, rsp); } } public void doBuild(StaplerRequest req, StaplerResponse rsp) throws IOException, ServletException { project.checkPermission(AbstractProject.BUILD); List<ParameterValue> values = new ArrayList<ParameterValue>(); List<ParameterDefinition> defs = new ArrayList<ParameterDefinition>(); Enumeration<?> names = req.getParameterNames(); while (names.hasMoreElements()) { String name = (String) names.nextElement(); defs.add(new StringParameterDefinition(name, null)); } for (ParameterDefinition d : defs) { StringParameterValue value = (StringParameterValue) d .createValue(req); if (value.value != null && !value.value.isEmpty()) { values.add(value); } } // Schedule build TimeDuration delay = new TimeDuration(project.getQuietPeriod()); CauseAction cause = new CauseAction(new Cause.UserIdCause()); ParametersAction params = new ParametersAction(values); Queue queue = Jenkins.getInstance().getQueue(); queue.schedule(project, delay.getTime(), params, cause); // send the user back to the job top page. rsp.sendRedirect("../"); } private List<ParameterDefinition> getParameterDefinitions() { List<ParameterDefinition> swarm = new ArrayList<ParameterDefinition>(); // Swarm parameters swarm.add(new StringParameterDefinition(ReviewProp.REVIEW.getProp(), null)); swarm.add(new StringParameterDefinition(ReviewProp.CHANGE.getProp(), null)); swarm.add(new StringParameterDefinition(ReviewProp.STATUS.getProp(), null)); swarm.add(new StringParameterDefinition(ReviewProp.PASS.getProp(), null)); swarm.add(new StringParameterDefinition(ReviewProp.FAIL.getProp(), null)); // Custom parameters swarm.add(new StringParameterDefinition(ReviewProp.LABEL.toString(), null)); return swarm; } final static Logger LOGGER = Logger.getLogger(ReviewAction.class.getName()); }
# | Change | User | Description | Committed | |
---|---|---|---|---|---|
#1 | 12955 | Sven Erik Knop | Branching using sknop.p4jenkins-main | ||
//guest/perforce_software/p4jenkins/main/src/main/java/org/jenkinsci/plugins/p4/review/ReviewAction.java | |||||
#5 | 11492 | Paul Allen | Minor Fix: first parent builds and label namespace | ||
#4 | 10755 | Paul Allen |
Separate name space for 'label' parameter. Perforce Review endpoint added `label`, `change`, `status`, `pass`, and `fail` parameter into the environment, which is a shared name space. This clashed with the default `label` matrix name and causing users issues. The change prefixes the review parameters with `p4.` on addition to the environment. |
||
#3 | 9702 | Paul Allen |
Fix for null/empty params on Build Review. Includes processing of custom (non Swarm) params. |
||
#2 | 9695 | Paul Allen | Merge: Moved reference for icon to /plugin/p4/ | ||
#1 | 9690 | Paul Allen |
[Branching using p4-jenkins] Release 1.0.1 |
||
//guest/paul_allen/dev/p4-jenkins/p4-client/src/main/java/org/jenkinsci/plugins/p4/review/ReviewAction.java | |||||
#1 | 9672 | Paul Allen | Refactor name from 'p4_client' to 'p4'. | ||
//guest/paul_allen/dev/p4-jenkins/p4-client/src/main/java/org/jenkinsci/plugins/p4_client/review/ReviewAction.java | |||||
#8 | 9055 | Paul Allen |
Label support. Build at a label using the pram 'label'. This includes adding the label to the ChangeEntry, building the change reports and Browser links to Swarm. (TPI-102) |
||
#7 | 8971 | Paul Allen |
Attempt to fix rootUrl bug, but ended up tidying code. Turns out that you MUST set the Jenkins URL and click Save; even though the box has a default value it is not applied unless the configuration page is Applied/Saved. Manage Jenkins --> Configuration --> Jenkins Location: Jenkins URL |
||
#6 | 8923 | Paul Allen | Remove unused parameters 'project' and 'branch' that might be the cause of TPI-81. | ||
#5 | 8737 | Paul Allen |
Added basic Help for SCM Configuration page. Tidy up descriptions and fix (null:null) in Credential summary. |
||
#4 | 8729 | Paul Allen |
Changed Build Review to Transient Action (so no check box required). - Added Perforce Icon to Build Review Action. |
||
#3 | 8693 | Paul Allen | Added manual launch Review page - POST from Jenkins. | ||
#2 | 8688 | Paul Allen | (Work in progress) Able to call build from review Action and pass URL params. | ||
#1 | 8683 | Paul Allen | Simple Action plugin hooks for building reviews in a Jenkins Job. |