test_bash_code_snippets.sh #2

  • //
  • p4-sdp/
  • dev_c2s/
  • test/
  • test_bash_code_snippets.sh
  • View
  • Commits
  • Open Download .zip Download (4 KB)
#!/bin/bash
#------------------------------------------------------------------------------
set -u

#==============================================================================
# Declarations and Environment
declare ThisScript=${0##*/}
declare CmdLine="$0 $*"
declare ThisUser=
declare ThisHost=${HOSTNAME%%.*}

declare -i Debug=${DEBUG:-1}
declare -i i=0
declare -i TestCount=0
declare -i PassCount=0
declare -i FailCount=0

# Version ID Block. Relies on +k filetype modifier.
#------------------------------------------------------------------------------
# shellcheck disable=SC2016
declare VersionID='$Id: //p4-sdp/dev_c2s/test/test_bash_code_snippets.sh#2 $ $Change: 31435 $'
declare VersionStream=${VersionID#*//}; VersionStream=${VersionStream#*/}; VersionStream=${VersionStream%%/*};
declare VersionCL=${VersionID##*: }; VersionCL=${VersionCL%% *}
declare Version=${VersionStream}.${VersionCL}

# Uppercase stream name in Version for unreleased builds.
[[ "$VersionStream" == r* ]] || Version="${Version^^}"

# ErrorCount is only incremented if the test could not be executed at all
# for some reason, and is independent of pass/fail status of a test.
###declare -i ErrorCount=0

#==============================================================================
# Local Functions.
function msg () { echo -e "$*"; }
function dbg () { [[ "$Debug" -eq 0 ]] || msg "DEBUG: $*"; }
function pass () { msg "PASS: $*"; PassCount+=1; TestCount+=1; }
function fail () { msg "FAIL: $*"; FailCount+=1; TestCount+=1; }
###function errmsg () { msg "\\nError: ${1:-Unknown Error}\\n"; ErrorCount+=1; }

#------------------------------------------------------------------------------
# Bash Code Snippet #1: Regex enabling regex.
#
# The first code snippet tested is the expression to confirm if SSL is enabled
# for a given P4PORT value. That looks like:
#
#   [[ $P4PORT =~ ^ssl[46]*: ]]
#
# The second expression extracts the SSL prefix. That looks like:
#
#   Prefix=${P4PORT%%:*}
#
# The second expression is only guaranteed to work if it is already confirmed
# that SSL is enabled.
#
# See: https://portal.perforce.com/s/article/1180
# Perforce Helix Core Server IPV6 Support

# Goal: Develop a tight bash regex to accurately detect all variants of
# SSL-enabling P4PORT prefixes, and only SSL-enabled ports (being aware
# of tricksy things like ssltech:1666 that might foil a loose regex).

declare -a PortList
declare -a SSLPort

PortList[i]=ssl:1666
SSLPort[i]=1
i+=1

PortList[i]=ssl::1666
SSLPort[i]=1
i+=1

PortList[i]=ssl:perforce:1666
SSLPort[i]=1
i+=1

PortList[i]=ssltech:1666
SSLPort[i]=0
i+=1

PortList[i]=ssltech:1666
SSLPort[i]=0
i+=1

PortList[i]=ssl64:1666
SSLPort[i]=1
i+=1

PortList[i]=ssl46:1999
SSLPort[i]=1
i+=1

PortList[i]=ssl4:1666
SSLPort[i]=1
i+=1

PortList[i]=ssl6:perforce:2020
SSLPort[i]=1
i+=1

PortList[i]=SSL6:1666 # Port prefixes are case-sensitive; lowercase only.
SSLPort[i]=0
i+=1

PortList[i]=ssl6:PERFORCE:1666 # Hosts are not case-sensitive.
SSLPort[i]=1
i+=1

#==============================================================================
# Main Program

dbg "VersionID:      $VersionID"
dbg "VersionStream:  $VersionStream"
dbg "VersionCL:      $VersionCL"
dbg "Version:        $Version"

ThisUser=$(id -n -u)
msg "Starting $ThisScript version $Version as $ThisUser@$ThisHost on $(date) as:\\n$CmdLine\\n"

#------------------------------------------------------------------------------
# This is for testing bash shell code snippets.
i=0; while [[ $i -lt ${#PortList[@]} ]]; do
   if [[ "${PortList[i]}" =~ ^ssl[46]*: ]]; then
      Prefix=${PortList[i]%%:*}
      if [[ "${SSLPort[i]}" -eq 1 ]]; then
         pass "P4PORT ${PortList[i]} is SSL-enabled (as expected). Prefix: $Prefix"
      else
         fail "P4PORT ${PortList[i]} is SSL-enabled (unexpected result). Prefix: $Prefix"
      fi
   else
      if [[ "${SSLPort[i]}" -eq 1 ]]; then
         fail "P4PORT ${PortList[i]} is not SSL-enabled (unexpected result)."
      else
         pass "P4PORT ${PortList[i]} is not SSL-enabled (as expected)."
      fi
   fi
   i+=1
done

if [[ "$FailCount" -eq 0 ]]; then
   msg "\\nAll $TestCount tests passed."
else
   msg "\\nOf $TestCount tests, $PassCount passed and $FailCount failed."
fi
# Change User Description Committed
#2 31435 C. Thomas Tyler Added illustration of new standard VersionID Block using +k filetype modifier.

After we migrate to Streams, the //p4-sdp/<stream> depot paths become useful for identifying the p4-sdp major version, which is tied to the p4d major version.  For example, the SDP r25.1 release will ship from the //p4-sdp/r25.1 release stream. This block will set the VersionID to for any given script to r25.1.<CL>, where CL is the latest changelist number to affect the given script.

Goals of this change:
* Enhance supportability by making it clear which release any given script version is released with.
* Provide clarity for the rare cases where customer is using an unreleased version, e.g. from a dev branch.
* Eliminate need for human manual bumping of the version number (via +k).
* Take full advantage of Streams structure.

Shellcheck compliance.

#review-31436
#1 31399 C. Thomas Tyler Populate -r -S //p4-sdp/dev_c2s.
//p4-sdp/dev/test/test_bash_code_snippets.sh
#1 31397 C. Thomas Tyler Populate -b SDP_Classic_to_Streams -s //guest/perforce_software/sdp/...@31368.
//guest/perforce_software/sdp/dev/test/test_bash_code_snippets.sh
#3 30276 C. Thomas Tyler Corrected comment to indicate the exact test used for checking if
SSL is enabled.
#2 29923 C. Thomas Tyler Updated HTML hyperlinks to use 'portal.perforce.com'.

This replaces currently broken links to 'answers.perforce.com' and
currently redirected links to 'community.perforce.com'.

#review-29924
#1 28641 C. Thomas Tyler Tweaked scripts to support IPv6 SSL prefixes.

Added test script to test bash code snippets. First test is the
snippet to check if SSL is enabled, and if so get the SSL prefix.