package VCP::Plugin ; =head1 NAME VCP::Plugin - A base class for VCP::Source and VCP::Dest =head1 SYNOPSIS use VCP::Plugin; @ISA = qw( VCP::Plugin ); ... =head1 DESCRIPTION Some functionality is common to sources and destinations, such as cache access, help text generation , command-line access shortcut member, etc. =head1 EXTERNAL METHODS =over =cut $VERSION = 0.1 ; use strict ; use File::Basename ; use File::Path qw( mkpath rmtree ); use File::Spec; use VCP::Logger qw( lg pr BUG ); use VCP::Revs; use VCP::Utils qw( is_win32 shell_quote xchdir start_dir ); #use fields ( # 'REVS', ## Any revisions we need to work with #); =item new Creates an instance, see subclasses for options. The options passed are usually native command-line options for the underlying repository's client. These are usually parsed and, perhaps, checked for validity by calling the underlying command line. =cut sub new { my $class = shift; return bless {}, $class; } =item plugin_documentation $text = $p->plugin_documentation; Returns the text of the DESCRIPTION section of a module's .pm as contained in VCP::Help. The DESCRIPTION returned is determined by $self. =cut sub plugin_documentation { my $self = shift; require VCP::Help; return VCP::Help->get( ref( $self ) . " description" ); } sub _reformat_docs_as_comments { ## This is used to convert help topics to inline comments for ## config files. my $self = shift; my $text = join "", @_; 1 while chomp $text; $text =~ s/^/ ## /mg; return "$text\n"; } =back =cut ############################################################################### =head1 SUBCLASSING This class uses the fields pragma, so you'll need to use base and possibly fields in any subclasses. =head2 SUBCLASS API These methods are intended to support subclasses. =over =item init This is called after new() and before processing. No attempt to connect to or open a repository or database file should be made until init() is called (ie not in new()). =cut sub init { } =item usage_and_exit GetOptions( ... ) or $self->usage_and_exit ; Used by subclasses to die if unknown options are passed in. =cut sub usage_and_exit { my $self = shift ; lg "options error emitted to STDERR for ", ref $self; require VCP::Help; print "\n"; VCP::Help->error( ref( $self ) . " usage" ); exit 2; } =item tmp_dir Returns the temporary directory this plugin should use, usually something like "/tmp/vcp123/dest-p4". =cut my @END_subs; =item queue_END_sub In order to provide ordered destruction and cleanup at application shutdown, plugins can queue up code to run before all directories are deleted. =cut sub queue_END_sub { my $self = shift; BUG "more than one sub passed to queue_END_sub" if @_ > 1; my ( $sub ) = @_; BUG "non-CODE ref passed to queue_END_sub" if ref $sub ne "CODE"; push @END_subs, $sub; } sub cancel_END_sub { my $self = shift; BUG "more than one sub passed to cancel_END_sub" if @_ > 1; my ( $sub ) = @_; BUG "non-CODE ref passed to cancel_END_sub" if ref $sub ne "CODE"; @END_subs = grep $_ ne $sub, @_; } my %tmp_dirs ; END { return unless keys %tmp_dirs; xchdir "/" if is_win32; ## WinNT can't delete out from ## under cwd. for ( @END_subs ) { eval { $_->(); 1 } or pr "cleanup error: $@"; } rmtree [ reverse sort { length $a <=> length $b } keys %tmp_dirs ] if ! $ENV{VCPNODELETE} && %tmp_dirs ; } sub tmp_dir { my $self = shift ; my $plugin_dir = ref $self ; $plugin_dir =~ tr/A-Z/a-z/ ; $plugin_dir =~ s/^VCP:://i ; $plugin_dir =~ s/::/-/g ; my $tmp_dir_root = File::Spec->catdir( start_dir, "tmp", "vcp$$" ) ; ## Make sure no old tmpdir is there to mess us up in case ## a previous run crashed before cleanup or $ENV{VCPNODELETE} is set. if ( ! $tmp_dirs{$tmp_dir_root} && -e $tmp_dir_root ) { pr "removing previous working directory $tmp_dir_root"; rmtree [$tmp_dir_root ], 0; } $tmp_dirs{$tmp_dir_root} = 1 ; return File::Spec->catdir( $tmp_dir_root, $plugin_dir, @_ ) ; } =item mkdir $self->mkdir( $filename ) ; $self->mkdir( $filename, $mode ) ; Makes a directory and any necessary parent directories. The default mode is 770. Does some debug logging if any directories are created. Returns nothing. =cut sub mkdir { my $self = shift ; my ( $path, $mode ) = @_ ; BUG "undefined \$path" unless defined $path; BUG "empty \$path" unless length $path; $path =~ s{/+$}{}; ## Let *BSD and other POSIXly correct system work unless ( -d $path ) { $mode = 0770 unless defined $mode ; lg "\$ ", shell_quote "mkdir", sprintf( "--mode=%04o", $mode ), $path; eval { mkpath [ $path ], 0, $mode } or die "failed to create $path with mode $mode: $@\n" ; } return ; } =item mkpdir $self->mkpdir( $filename ) ; $self->mkpdir( $filename, $mode ) ; Makes the parent directory of a filename and all directories down to it. The default mode is 770. Does some debug logging if any directories are created. Returns the path of the parent directory. =cut sub mkpdir { my $self = shift ; my ( $path, $mode ) = @_ ; my ( undef, $dir ) = fileparse $path; $self->mkdir( $dir, $mode ) ; return $dir ; } =back =head1 COPYRIGHT Copyright 2000, Perforce Software, Inc. All Rights Reserved. This module and the VCP package are licensed according to the terms given in the file LICENSE accompanying this distribution, a copy of which is included in L<vcp>. =head1 AUTHOR Barrie Slaymaker <barries@slaysys.com> =cut 1
# | Change | User | Description | Committed | |
---|---|---|---|---|---|
#1 | 6119 | Dimitry Andric | Create branch from //public/revml, changelist 5088, since I originally started making changes to this version. | ||
//guest/perforce_software/revml/lib/VCP/Plugin.pm | |||||
#69 | 4143 | Barrie Slaymaker | - Further adaptation to vcp.exe packaging format | ||
#68 | 4077 | Barrie Slaymaker |
- VCP on Win32 no longer whines about permission denied errors for some disk file cleanup tasks. |
||
#67 | 4021 | Barrie Slaymaker |
- Remove all phashes and all base & fields pragmas - Work around SWASHGET error |
||
#66 | 4012 | Barrie Slaymaker | - Remove dependance on pseudohashes (deprecated Perl feature) | ||
#65 | 3970 | Barrie Slaymaker |
- VCP::Source handles rev queing, uses disk to reduce RAM - Lots of other fixes |
||
#64 | 3862 | Barrie Slaymaker |
- Use start_dir/tmp for tempdir locations so that VCP::Source::revml, which stashes files under star_dir/vcp_state, allows those files to be link()ed |
||
#63 | 3855 | Barrie Slaymaker |
- vcp scan, filter, transfer basically functional - Need more work in re: storage format, etc, but functional |
||
#62 | 3753 | Barrie Slaymaker | - mkdir() trims trailing slashes for *BSD and POSIXly correct oses | ||
#61 | 3491 | Barrie Slaymaker | - All sections are now documented in generated config files | ||
#60 | 3460 | Barrie Slaymaker |
- Revamp Plugin/Source/Dest hierarchy to allow for reguritating options in to .vcp files |
||
#59 | 3439 | Barrie Slaymaker | - Temp dir cleanup now works better on Win32 | ||
#58 | 3429 | Barrie Slaymaker |
- Refactor db_location() into VCP::Plugin so VCP::Source::vss will be able to use it. |
||
#57 | 3417 | Barrie Slaymaker | - Win32 adaptation | ||
#56 | 3402 | Barrie Slaymaker |
- now passes all tests using the p4 api library. (still not default, set env var VCPP4API=1) - foo->p4 handles branch-but-no-change case when --change-branch-rev-1 is passed. - sources & dests can now provide their own command execution routine in place of shelling out to an external command (as in call the p4api library instead of running the p4 command). |
||
#55 | 3376 | John Fetkovich | small changes | ||
#54 | 3287 | John Fetkovich | Allow parse_options to silently ignore the lack of options array. | ||
#53 | 3284 | John Fetkovich |
'sub new' constructor in Source and Dest p4.pm fixed so parse_p4_repo_spec only called when a $spec is provided to the constructor. parse_p4_repo_spec now also sets the repo_id. parse_repo_spec (TODO item) no longer returns a hash value of the values parsed, it only sets fields in $self. Fixed a few places where that return hash was used. |
||
#52 | 3283 | John Fetkovich | argument checking | ||
#51 | 3271 | John Fetkovich |
Added stub init() in VCP/Plugin.pm, and call to it in load_module in bin/vcp. This is in preparation for Sources and Dests to have parts of their current constructors split out into init() functions which will facilitate setting of fields from the interative ui code. |
||
#50 | 3170 | Barrie Slaymaker |
Clean up _run3 a bit. Avoid Carp; use BUG. |
||
#49 | 3167 | Barrie Slaymaker |
Add profiling report that details various chunks of time taken. |
||
#48 | 3163 | Barrie Slaymaker |
Keep system() from flushing STDOUT to the tmpfiles that _run3() uses. |
||
#47 | 3161 | Barrie Slaymaker | _run3 can now capture STDOUT to a CODE ref. | ||
#46 | 3155 | Barrie Slaymaker |
Convert to logging using VCP::Logger to reduce stdout/err spew. Simplify & speed up debugging quite a bit. Provide more verbose information in logs. Print to STDERR progress reports to keep users from wondering what's going on. Breaks test; halfway through upgrading run3() to an inline function for speed and for VCP specific features. |
||
#45 | 3129 | Barrie Slaymaker |
Stop calling the slow Cwd::cwd so much, use start_dir instead. |
||
#44 | 3120 | Barrie Slaymaker | Move changeset aggregation in to its own filter. | ||
#43 | 3099 | Barrie Slaymaker | Code cleanup | ||
#42 | 3014 | Barrie Slaymaker | minor warnings cleanups | ||
#41 | 3012 | Barrie Slaymaker | Report stderr of child if it returns an unnaceptable result code. | ||
#40 | 2958 | Barrie Slaymaker | Avoid undef warning, improve output by properly quoting cmd. | ||
#39 | 2952 | John Fetkovich | removed old run_safely, and renamed run_safely_new to run_safely. | ||
#38 | 2853 | John Fetkovich | removed some debugging output | ||
#37 | 2809 | Barrie Slaymaker |
Implement --repo-id in Plugin.pm, refactor source & dest options parsing starting in VCP::Source::cvs (need to roll out to other sources and dests), get t/91cvs2revml.t passing again (first time in months! branching and --continue support works in cvs->foo!). |
||
#36 | 2802 | John Fetkovich |
Added a source_repo_id to each revision, and repo_id to each Source and Dest. The repo_ids include repository type (cvs,p4,revml,vss,...) and the repo_server fields. Changed the $self->...->set() and $self->...->get() lines in VCP::Dest::* to pass in a conglomerated key value, by passing in the key as an ARRAY ref. Also various restructuring in VCP::DB.pm, VCP::DB_file.pm and VCP::DB_file::sdbm.pm related to this change. |
||
#35 | 2752 | John Fetkovich | improve IPC::Run debug msg | ||
#34 | 2743 | John Fetkovich |
Add fields to vcp: source_name, source_filebranch_id, source_branch_id, source_rev_id, source_change_id 1. Alter revml.dtd to include the fields 2. Alter bin/gentrevml to emit legal RevML 3. Extend VCP::Rev to have the fields 4. Extend VCP::{Source,Dest}::revml to read/write the fields (VCP::Dest::revml should die() if VCP tries to emit illegal RevML) 5. Extend VCP::{Source,Dest}::{cvs,p4} to read the fields 7. Get all tests through t/91*.t to pass except those that rely on ch_4 labels |
||
#33 | 2719 | Barrie Slaymaker |
Improve error reporting, allow run_safely's in_dir to be relative to the default command_chdir setting |
||
#32 | 2665 | John Fetkovich | change to permit profiling via unix 'time' command in run_safely_new | ||
#31 | 2664 | Barrie Slaymaker | Try IPC::Run3 to see if it speeds up p4 calls | ||
#30 | 2655 | John Fetkovich |
Added usage of 'nix time command to run_safely in Utils.pm when profiling is turned on. |
||
#29 | 2415 | John Fetkovich | POD documentation fixes. | ||
#28 | 2293 | Barrie Slaymaker | Update CHANGES, TODO, improve .vcp files, add --init-cvs | ||
#27 | 2267 | Barrie Slaymaker | factor out cvs2revml, test both --use-cvs and direct modes, with times | ||
#26 | 2245 | Barrie Slaymaker | cvs -r (re)implemented for direct reads, passes all cvs-only tests | ||
#25 | 2049 | Barrie Slaymaker | Get branching working in Dest::p4, clean up some tests. | ||
#24 | 2026 | Barrie Slaymaker | VCP::8::cvs now supoprt branching | ||
#23 | 2018 | Barrie Slaymaker | tweak | ||
#22 | 2015 | Barrie Slaymaker | submit changes | ||
#21 | 2009 | Barrie Slaymaker |
lots of fixes, improve core support for branches and VCP::Source::cvs now supports branches. |
||
#20 | 2006 | Barrie Slaymaker |
more preparations for branching support, handling of cvs :foo:... CVSROOT specs, misc fixes, improvements |
||
#19 | 1998 | Barrie Slaymaker | Initial, revml and core VCP support for branches | ||
#18 | 1822 | Barrie Slaymaker |
Get all other tests passing but VSS. Add agvcommenttime sort field. |
||
#17 | 1809 | Barrie Slaymaker | VCP::Patch should ignore lineends | ||
#16 | 1728 | Barrie Slaymaker | CVS on win32, minor bugfixes | ||
#15 | 1358 | Barrie Slaymaker | Win32 changes | ||
#14 | 719 | Barrie Slaymaker | vcp 0.221 | ||
#13 | 705 | Barrie Slaymaker | Release 0.22. | ||
#12 | 692 | Barrie Slaymaker |
Add VCP::Utils::p4 and use it to get VCP::Dest::p4 to create it's own client view as needed. |
||
#11 | 687 | Barrie Slaymaker | remove -f, tweak deduce_rev_root | ||
#10 | 628 | Barrie Slaymaker | Cleaned up POD in bin/vcp, added BSD-style license. | ||
#9 | 627 | Barrie Slaymaker | Beef up CVS log file parsing. | ||
#8 | 609 | Barrie Slaymaker |
Add a file to the test procedure that it alternately added and deleted (file is named "readd"). Fixed all destinations to handle that. |
||
#7 | 608 | Barrie Slaymaker |
Lots of changes to get vcp to install better, now up to 0.066. Many thanks to Matthew Attaway for testing & suggestions. |
||
#6 | 480 | Barrie Slaymaker |
0.06 Wed Dec 20 23:19:15 EST 2000 - bin/vcp: Added --versions, which loads all modules and checks them for a $VERSION and print the results out. This should help with diagnosing out-of-sync modules. - Added $VERSION vars to a few modules :-). Forgot to increment any $VERSION strings. - VCP::Dest::cvs: The directory "deeply" was not being `cvs add`ed on paths like "a/deeply/nested/file", assuming "deeply" had no files in it. - VCP::Dest::revml: fixed a bug that was causing files with a lot of linefeeds to be emitted in base64 instead of deltaed. This means most text files. - Various minor cleanups of diagnostics and error messages, including exposing "Can't locate Foo.pm" when a VCP::Source or VCP::Dest module depends on a module that's not installed, as reported by Jeff Anton. |
||
#5 | 478 | Barrie Slaymaker |
0.05 Mon Dec 18 07:27:53 EST 2000 - Use `p4 labels //...@label` command as per Rober Cowham's suggestion, with the '-s' flag recommended by Christopher Siewald and Amaury.FORGEOTDARC@atsm.fr. Though it's actually something like vcp: running /usr/bin/p4 -u safari -c safari -p localhost:5666 -s files //.../NtLkly //...@compiler_a3 //.../NtLkly //...@compiler_may3 and so //on //for 50 parameters to get the speed up. I use the //.../NtLkly "file" as //a separator between the lists of files in various //revisions. Hope nobody has any files named that :-). What I should do is choose a random label that doesn't occur in the labels list, I guess. - VCP::Source::revml and VCP::Dest::revml are now binary, control code, and "hibit ASCII" (I know, that's an oxymoron) clean. The <comment>, <delta>, and <content> elements now escape anything other than tab, line feed, space, or printable chars (32 <= c <= ASCII 126) using a tag like '<char code="0x09">'. The test suite tests all this. Filenames should also be escaped this way, but I didn't get to that. - The decision whether to do deltas or encode the content in base64 is now based on how many characters would need to be escaped. - We now depend on the users' diff program to have a "-a" option to force it to diff even if the files look binary to it. I need to use Diff.pm and adapt it for use on binary data. - VCP::Dest::cvs now makes sure that no two consecutive revisions of the same file have the same mod_time. VCP::Source::p4 got so fast at pulling revisions from the repositories the test suite sets up that CVS was not noticing that files had changed. - VCP::Plugin now allows you to set a list of acceptable result codes, since we now use p4 in ways that make it return non-zero result codes. - VCP::Revs now croaks if you try to add two entries of the same VCP::Rev (ie matching filename and rev_id). - The <type> tag is now limited to "text" or "binary", and is meant to pass that level of info between foreign repositories. - The <p4_info> on each file now carries the one line p4 description of the file so that p4->p4 transferes can pick out the more detailed info. VCP::Source::p4, VCP::Dest::p4 do this. - VCP::{Source,Dest}::{p4,cvs} now set binaryness on added files properly, I think. For p4->p4, the native p4 type is preserved. For CVS sources, seeing the keyword substitution flag 'o' or 'b' implies binaryness, for p4, seeing a filetype like qr/u?x?binary/ or qr/x?tempobj/ or "resource" implies binaryness (to non-p4 destinations). NOTE: Seeing a 'o' or 'b' in a CVS source only ends up setting the 'b' option on the destination. That should be ok for most uses, but we can make it smarter for cvs->cvs transfers if need be. |
||
#4 | 473 | Barrie Slaymaker |
0.04 Tue Dec 12 00:15:57 EST 2000 - Reorg of VCP::Source::p4 - One large filelog command is run instead of many small ones. This takes advantage of the -m option to make sure enough changes are listed. Many extra revisions of most files are probably listed, but listing and ignoring them is quicker than spawning p4 over and over. Wish p4 filelog had a revision range... - it now doesn't suck the entire filelog output in to memory, it parses it line by line as it's emitted from the `p4 filelog` - `p4 print` is now used to print a bunch of files at once, using the header line to separate one file from the next, kind of like splitting a mime-encoded message. There's a very slight chance that it will misjudge the boundary between two files if a file happens to have a line that looks very much like the header line for the next file. This is pretty unlikely and I'll fix it if it crops up. I could batch them more, right now it never puts two revisions of the same filename in the same batch, for no really good reason. Another method might be to batch 25 or 50 revs each time. - it turns out there's a problem spawning multiple p4 commands at the same time against the same p4d (p4d is 99.2, FWIW). Or at least running large `p4 files ...` while there's a large `p4 filelog` still also running. - filelog lines beginning with "... ..." are now ignored. These are notifications of copy, branch, and integrate events that we don't yet do anything with. - deleted cur() and P4_CUR - deleted P4_IS_INCREMENTAL - Made an assertion in VCP::Dest::revml::handle_rev() a little clearer - Added some ok(1) calls to 90p4.t to make it easier to figure out which child process is whining or aborting - Made the message that's printed when a subcommand emits unexpected output say "stderr" instead of "stdout". - Cleaned up documentation for VC::Plugin::work_path(). |
||
#3 | 470 | Barrie Slaymaker |
- Cleaned up VCP::Source::p4 a bit. It doesn't whine as much now when it sees what it considers to be old news in the log file. - Added an easy way to monitor the commands being issued to a repository: simply add "::cmd" to the debug spec for that source: vcp -d Source::cvs::cvs vcp -d Dest::p4::p4 - The next step is to use the -m option to p4 filelog to speed things up. |
||
#2 | 468 | Barrie Slaymaker |
- VCP::Dest::p4 now does change number aggregation based on the comment field changing or whenever a new revision of a file with unsubmitted changes shows up on the input stream. Since revisions of files are normally sorted in time order, this should work in a number of cases. I'm sure we'll need to generalize it, perhaps with a time thresholding function. - t/90cvs.t now tests cvs->p4 replication. - VCP::Dest::p4 now doesn't try to `p4 submit` when no changes are pending. - VCP::Rev now prevents the same label from being applied twice to a revision. This was occuring because the "r_1"-style label that gets added to a target revision by VCP::Dest::p4 could duplicate a label "r_1" that happened to already be on a revision. - Added t/00rev.t, the beginnings of a test suite for VCP::Rev. - Tweaked bin/gentrevml to comment revisions with their change number instead of using a unique comment for every revision for non-p4 t/test-*-in-0.revml files. This was necessary to test cvs->p4 functionality. |
||
#1 | 467 | Barrie Slaymaker | Version 0.01, initial checkin in perforce public depot. |