#!/usr/bin/env python USAGE = """ This script will remove the specified users from given group. Usage: removeusersfromgroup.py [instance] USER groupname removeusersfromgroup.py [instance] FILE groupname USER can be a single username or, it can be a FILE with a list of users. instance defaults to 1 if not given. """ import os import sys import sdputils if len(sys.argv) > 3: # see params above SDP_INSTANCE = str(sys.argv) else: SDP_INSTANCE = '1' utils = sdputils.SDPUtils(SDP_INSTANCE) p4 = utils.p4 utils.login() def removeuser(username, groupname, groupfile): newgroupfile = groupfile + ".new" infile = open(groupfile, "r") outfile = open(newgroupfile, "w") for line in infile.readlines(): if username.lower() != (line.strip()).lower(): outfile.write(line) infile.close() outfile.close() os.remove(groupfile) os.rename(newgroupfile, groupfile) def cleanup(groupfile): print("Cleaning temp files") try: os.remove(groupfile) except: print("Failed to delete " + groupfile) def main(): if len(sys.argv) < 3: print(USAGE) sys.exit(1) # Handle the optional instance parameter shift if len(sys.argv) > 3: userorfile = (sys.argv) groupname = sys.argv.strip() else: userorfile = (sys.argv) groupname = sys.argv.strip() global initialized initialized = 0 groupfile = "%s.group" % groupname os.system("%s group -o %s > %s" % (p4, groupname, groupfile)) try: userlistfile = open(userorfile, "r") for line in userlistfile.readlines(): removeuser(line.strip(), groupname, groupfile) except: print("No file %s available, assuming it is the actual user name." % userorfile) removeuser(userorfile, groupname, groupfile) os.system("%s group -i < %s" % (p4, groupfile)) cleanup(groupfile) if __name__ == '__main__': main()
This supercedes review-24715.
Bringing over recent bug fixes and code clean up from Rusty Jackson's local branch.
Adds an edge maintenance script to unload clients on edge servers.
Automated setting up maintenance.cfg from mkdirs.cfg settings.
Cleaned up sdputils.py - It had a logic bug, and fixed all scripts based on changes.
== Merge Details ==
Merge strategy: All the fixes to Maintenance scripts were brought in, but not the changes to active them in crontab that would enable them.
Rusty's original change had crontab changes to call maintenance scripts, and also calls to 'p4 unlock -x' as a workround to p4d bugs related to orphanged locks on edge servers. Those bugs are already fixed. Also, adding anything new to cron requires a test suite addition and doc updates. So changes to the template.crontab.combined were ignored. However, a new file was added to the Maintenace folder, sample_cron_entries.txt, to make it easy for folks to see those changes.
Rusty's original change had mkdirs.sh changes to generate maintenance.cfg. This change was enhanced during the merge. Rather than overwriting maintenance.cfg (potentially blowing away configuration for other instances), a new section for the new instance is appended to maintenance.cfg when 'mkdirs.sh <instance>' is run.
Future considerations: Before adding anything from Maintenance to cron, we need to do the following:
* Have mkdirs.sh install the Maintenance folder to the as-deployed structure under /p4/common, i.e. to /p4/common/maintenance, for HMS management compliance.
* Add tests and docs for each script called (directly or indirectly).
Routine merge down to dev from main using:
p4 merge -b perforce_software-sdp-dev
Routine merge to dev from main using:
p4 merge -b perforce_software-sdp-dev
Normalized P4INSTANCE to SDP_INSTANCE to get Unix/Windows
implementations in sync.
1. Things that interact with SDP in both Unix and Windows
environments shoudn't have to account for this obscure
SDP difference between Unix and Windows. (I came across
this doing CBD work).
2. The Windows and Unix scripts have different variable
names for defining the same concept, the SDP instance.
Unix uses P4INSTANCE, while Windows uses SDP_INSTANCE.
3. This instance tag, a data set identifier, is an SDP concept.
I prefer the SDP_INSTANCE name over P4INSTANCE, so I prpose
to normalize to SDP_INSTANCE.
4. The P4INSTANCE name makes it look like a setting that might be
recognized by the p4d itself, which it is not. (There are other
such things such as P4SERVER that could perhaps be renamed as
a separate task; but I'm not sure we want to totally disallow
the P4 prefix for variable names. It looks too right to be wrong
in same cases, like P4BIN and P4DBIN. That's a discussion for
another day, outside the scope of this task).
* Fixed a bug in the Windows 2013.3 upgrade script that
was referencing undefined P4INSTANCE, as the Windows
environment defined only SDP_INSTANCE.
* Had P4INSTANCE been removed completely, this change would
likely cause trouble for users doing updates for existing
SDP installations. So, though it involves slight technical debt,
I opted to keep a redundant definition of P4INSTANCE
in p4_vars.template, with comments indicating SDP_INSTANCE should be
used in favor of P4INSTANCE, with a warning that P4INSTANCE
may go away in a future release. This should avoid unnecessary
* In mkdirs.sh, the varialbe name was INSTANCE rather than
SDP_INSTANCE. I changed that as well. That required manual
change rather than sub/replace to avoid corrupting other similar
varialbe names (e.g. MASTERINSTANCE).
This is a trivial change technically (a substitute/replace, plus
tweaks in p4_vars.template), but impacts many files.
Updated to use /usr/bin/env python
Added workshop header.
Changed cfg to config.
|#2||11464||russell_jackson||Current maintenance scripts.|
|#1||10148||tom_tyler||Promoted the Perforce Server Deployment Package to The Workshop.|