#!/bin/bash #------------------------------------------------------------------------------ # Copyright (c) Perforce Software, Inc., 2007-2014. All rights reserved # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions are met: # # 1 Redistributions of source code must retain the above copyright # notice, this list of conditions and the following disclaimer. # # 2. Redistributions in binary form must reproduce the above copyright # notice, this list of conditions and the following disclaimer in the # documentation and/or other materials provided with the distribution. # # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS # FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL PERFORCE # SOFTWARE, INC. BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON # ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF # THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH # DAMAGE. #------------------------------------------------------------------------------ # # Perforce proxy base init script # do nothing unless $P4INSTANCE is defined. if [ -z $P4INSTANCE ] then echo $P4INSTANCE echo "P4INSTANCE is invalid." exit 1 fi if [ `$ID -u` = 0 ]; then exec su - $OSUSER -c "$0 $1" elif [ "`$ID -u -n`" != $OSUSER ]; then echo "$0 can only be run by root or $OSUSER" exit 1 fi # Souce in get_pids(). source $P4CBIN/ps_functions.sh || exit 1 # Add and override values from p4_vars export P4LOG=$LOGS/p4p.log export P4P_FLAGS="-d -p $PROXY_PORT -r $P4PCACHE -t $PROXY_TARGET -e 3072 -L $P4LOG" case "$1" in start) echo "Starting ${P4PBIN} ${P4P_FLAGS}" ${P4PBIN} ${P4P_FLAGS} ;; status) p4p_pids=$(get_pids "$P4PBIN") if [[ -n "$p4p_pids" ]]; then echo "${P4PBIN} is running as pids: $p4p_pids." exit 0 else echo "${P4PBIN} is NOT running." exit 1 fi ;; stop) p4p_pids=$(get_pids "$P4PBIN") if [[ -n "$p4p_pids" ]]; then while [[ -n "$p4p_pids" ]]; do echo "Shutting down ${P4PBIN} pids: $p4p_pids." kill $p4p_pids 2>&1 | $GREP -v -i "No such" sleep 1 p4p_pids=$(get_pids "$P4PBIN") done echo "${P4PBIN} stopped." exit 0 else echo "${P4PBIN} was NOT running." exit 1 fi ;; restart) $0 stop $0 start ;; *) echo "Usage: $0 {start|stop|status|restart}" exit 1 ;; esac
# | Change | User | Description | Committed | |
---|---|---|---|---|---|
#25 | 30523 | C. Thomas Tyler |
This is a fix to an unreleased version of p4p_base; a iteration on that earlier dev branch change. No release notes needed. Revised based on feedback on https://swarm.workshop.perforce.com/reviews/30510 fixing a bug where PROXY_V_FLAGS was ignored. #review-30524 |
||
#24 | 30509 | C. Thomas Tyler |
Tweaked proxy handling to generate a cleaner command line (as seen in ps -ef), eliminating null or duplicate values for proxy.monitor.level setting. This change makes p4d_base more robust even inf the instance vars settings are slightly misconfigured, e.g. a null value for PROXY_MON_LEVEL. #review-30510 |
||
#23 | 30266 | C. Thomas Tyler |
Added logic surrounding 'ulimit -c unlimited' to avoid calling 'ulimit' on systems on which it is doomed to fail with an 'Operation not permitted' error. |
||
#22 | 30127 | C. Thomas Tyler |
Enhanced p4d_base to start p4d from the P4ROOT directory and to set 'ulimit -c unlimited' to enable core dumps. Similar was done for p4p_base and p4broker_base. For best results, combine this with doing the following as root on p4d server machines: bash -c "echo 'core.%e.%p.%s' > /proc/sys/kernel/core_pattern" This wll generate core files for p4d in $P4ROOT, something like this: /p4/1/root/core.p4d_1.2351279.11 For p4p, core dumps appear in the $P4PCACHE dir. For p4broker, core dumps appear in the $LOGS dir. Also added version identifier that is captured in systemctl status output. #review-30128 |
||
#21 | 29746 | C. Thomas Tyler |
Moved proxy '-e 3072' flag from p4p_base to Instance Vars file so it can be changed on a per-instance basis. It is now part of the def'n of PROXY_V_FLAGS. Moved PROXY_MON_LEVEL from p4_vars to Instance Vars file so it can be changed on a per-instance basis. Updated format settings in sdp_upgrade.sh, and added PROXY_MON_LEVEL to list of user settings to be preserved during SDP upgrades. #review-29747 |
||
#20 | 29101 | C. Thomas Tyler |
Added implicit trust of target servers for p4p/p4broker on 'start', and added trust of local proxy/broker ports on 'status'. #review-29102 |
||
#19 | 29100 | C. Thomas Tyler |
Removed requirement for systemd *.service files to have open perms in *_base scripts and templates. Removed checks for open perms on *.service files in verify_sdp.sh. Fixed minor ShellCheck compliance issue. See also: HI-101: https://swarm.workshop.perforce.com/jobs/HI-101 [Submitting, then re-opening for post-commit final review]. |
||
#18 | 28369 | Robert Cowham |
Add explanation message for p4d_base when systemd file not correct. Move warning about p4d journal validation and only output on error. Avoids unnecessary alarms. |
||
#17 | 28342 | C. Thomas Tyler |
Added PROXY_V_FLAGS setting to provide a clean way to add proxy settings like "-v net.autotune=1". |
||
#16 | 27206 | C. Thomas Tyler | More minor message refinements. | ||
#15 | 27205 | C. Thomas Tyler | Cosmetic refinement to error message. | ||
#14 | 27109 | C. Thomas Tyler |
Refined logic so that if a shutdown is attempted and there is no server.pid file, the 'fallback/2nd pass/assured shutdown' logic to do a 'p4 admin stop' files only if a 'p4 info' command can reach the server. Otherwise, the stop command is silently ignored. Refined exit code handling and fixed log interaciton issues. Fixed issue with systemd status not indicating successful startup. The systemd unit files now specify the Type as simple rather than forking, and defer to systemd to handle the forking. When systemd is used, the -d/--daemonsafe flags are removed from service start commands for p4p/p4broker/p4d, and for p4dtg the & is removed so the process is not started in the background. For compatibility with non-systemd systems, the -d/--daemonsafe flags are still applied when systemd is not in use. With this change, systemd's concept of whether the service is running should now be reliable. If you try to start without using systemd on a system for which a systemd unit file exists, an error is displayed -- a big, hopefully useful and informative error message. #review |
||
#13 | 26399 | C. Thomas Tyler |
Shellcheck compliance tweaks. Fixed quoting bug in unrelease dev branch version. Added startDelay to p4broker_base and p4p_base. |
||
#12 | 23040 | C. Thomas Tyler |
Enhancements to p4d_base: * Added $LOGS/p4d_init.log to track calls to init. * Increased verbosity somewhat, though the 'p4d -xvu' output still goes only to the p4d_init.log, with an error message referencing that log in event of error. * Replaced old preflight log with standard LOGFILE for all tracking. * Fixed issue starting server due to LOGFILE not being defined; not documented as a bug since it is a fix to unreleased behavior in the last change in the dev branch. * Enhanced to automatically replace '-d' with '--daemonsafe' if p4d 2017.1+ * Enhanced to call p4login rather than duplicating logic in p4login. No rotation is provided for p4d_init.log; it is continuously appended and is expected to grow only a few M per year with typical usage (the bigger the server, the less the growth). Enhancements to all *_base scripts: * Enhanced so default behvaior, with no args, is to show a usage message (rather than doing 'status'). |
||
#11 | 21808 | C. Thomas Tyler |
Routine merge down to dev from main, picking up change from akwan: update p4p_base to incorporate proxy monitoring and set default value in p4_vars |
||
#10 | 20559 | C. Thomas Tyler |
Fixed recent regression with 'restart' option in init scripts; they now need to pass in the SDP_INSTANCE parameter. Also corrected usage messages. |
||
#9 | 20491 | C. Thomas Tyler |
Fixed an environment insulation bug in init scripts. More testing (and thinking) revealed that the only way to truly provide a guarantee of insulation from user-set defaults in ~perforce/.bashrc (etc.) is to pass SDP_INSTANCE as a parameter to the *_base scripts, so that the instance name is explicitly passed into the su/exec call (when run as root). This change also includes minor cleanup in init scripts and *_base scripts. |
||
#8 | 20448 | C. Thomas Tyler |
Fixed env bug seen when running init scripts as root. Updated *_base scripts and *_init script templates to a new standard. Goals: 1. Init scripts that use corresponding *_base scripts are minimized so that do nothing more than set SDP_INSTANCE and then call the corresponding *_base script. 2. The 'su' commands always pass $* instead of $1, deferring all processing to the *_base script. 3. The shell environment is now guaranteeds to have the same results regardless of whether it is called as 'root' or as the defined OSUSER. 4. The p4_vars file is always sourced exactly once. Two calls to 'source p4_vars' appear in some cases, one immediatley before the su/exec call, and another after the after the 'su/exec'. Only one or the other is sourced. 5. All init scripts have a reasonably consistent usage message. 6. All init scripts accept a 'status' argument. This change fixes a bug where 'p4broker_N_init status' run as the 'perforce' user would report many pids unrelated to Perforce if run as root, e.g. doing 'service p4broker_N_init status'. This also eliminates a potential issue where the 'perforce' user might source a p4_vars with a default instance in ~/.profile or ~/.bashrc, thus invalidating the instance specified when the user ran the init script as root. |
||
#7 | 16458 | C. Thomas Tyler |
Routine Merge Down to dev from main using: p4 merge -b perforce_software-sdp-dev |
||
#6 | 16029 | C. Thomas Tyler |
Routine merge to dev from main using: p4 merge -b perforce_software-sdp-dev |
||
#5 | 15778 | C. Thomas Tyler | Routine Merge Down to dev from main. | ||
#4 | 13906 | C. Thomas Tyler |
Normalized P4INSTANCE to SDP_INSTANCE to get Unix/Windows implementations in sync. Reasons: 1. Things that interact with SDP in both Unix and Windows environments shoudn't have to account for this obscure SDP difference between Unix and Windows. (I came across this doing CBD work). 2. The Windows and Unix scripts have different variable names for defining the same concept, the SDP instance. Unix uses P4INSTANCE, while Windows uses SDP_INSTANCE. 3. This instance tag, a data set identifier, is an SDP concept. I prefer the SDP_INSTANCE name over P4INSTANCE, so I prpose to normalize to SDP_INSTANCE. 4. The P4INSTANCE name makes it look like a setting that might be recognized by the p4d itself, which it is not. (There are other such things such as P4SERVER that could perhaps be renamed as a separate task; but I'm not sure we want to totally disallow the P4 prefix for variable names. It looks too right to be wrong in same cases, like P4BIN and P4DBIN. That's a discussion for another day, outside the scope of this task). Meanwhile: * Fixed a bug in the Windows 2013.3 upgrade script that was referencing undefined P4INSTANCE, as the Windows environment defined only SDP_INSTANCE. * Had P4INSTANCE been removed completely, this change would likely cause trouble for users doing updates for existing SDP installations. So, though it involves slight technical debt, I opted to keep a redundant definition of P4INSTANCE in p4_vars.template, with comments indicating SDP_INSTANCE should be used in favor of P4INSTANCE, with a warning that P4INSTANCE may go away in a future release. This should avoid unnecessary upgrade pain. * In mkdirs.sh, the varialbe name was INSTANCE rather than SDP_INSTANCE. I changed that as well. That required manual change rather than sub/replace to avoid corrupting other similar varialbe names (e.g. MASTERINSTANCE). This is a trivial change technically (a substitute/replace, plus tweaks in p4_vars.template), but impacts many files. |
||
#3 | 12169 | Russell C. Jackson (Rusty) |
Updated copyright date to 2015 Updated shell scripts to require an instance parameter to eliminate the need for calling p4master_run. Python and Perl still need it since you have to set the environment for them to run in. Incorporated comments from reviewers. Left the . instead of source as that seems more common in the field and has the same functionality. |
||
#2 | 10852 | Domenic |
Base proxy script updates. - Remove p4broker references. - Fix "stop" command for the service to get p4p_pids instead of p4broker_pids. |
||
#1 | 10638 | C. Thomas Tyler | Populate perforce_software-sdp-dev. | ||
//guest/perforce_software/sdp/main/Server/Unix/p4/common/bin/p4p_base | |||||
#1 | 10148 | C. Thomas Tyler | Promoted the Perforce Server Deployment Package to The Workshop. |